Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752218AbdFZOGg (ORCPT ); Mon, 26 Jun 2017 10:06:36 -0400 Received: from mx2.suse.de ([195.135.220.15]:45010 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751582AbdFZOG2 (ORCPT ); Mon, 26 Jun 2017 10:06:28 -0400 From: Michal Suchanek To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Hari Bathini , Mahesh Salgaonkar , Andrew Morton , Michal Suchanek , Colin Ian King , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] powerpc/fadump: return 0 on re-registration Date: Mon, 26 Jun 2017 16:06:00 +0200 Message-Id: <20170626140601.7106-1-msuchanek@suse.de> X-Mailer: git-send-email 2.10.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 821 Lines: 26 When fadump is already registered return success. Currently EEXIST is returned which is difficult to handle race-free in userspace when shell scripts are used. If multiple writers are trying to write '1' there is no difference in whichever succeeds so just return 0 to all. Signed-off-by: Michal Suchanek --- arch/powerpc/kernel/fadump.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c index 436aedf195ab..5a7355381dac 100644 --- a/arch/powerpc/kernel/fadump.c +++ b/arch/powerpc/kernel/fadump.c @@ -1214,7 +1214,6 @@ static ssize_t fadump_register_store(struct kobject *kobj, break; case '1': if (fw_dump.dump_registered == 1) { - ret = -EEXIST; goto unlock_out; } /* Register Firmware-assisted dump */ -- 2.10.2