Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751473AbdFZRhP (ORCPT ); Mon, 26 Jun 2017 13:37:15 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:22651 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751101AbdFZRhI (ORCPT ); Mon, 26 Jun 2017 13:37:08 -0400 To: Seth Forshee Cc: Adaptec OEM Raid Solutions , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: aacraid: Don't copy uninitialized stack memory to userspace From: "Martin K. Petersen" Organization: Oracle Corporation References: <20170623140422.30320-1-seth.forshee@canonical.com> Date: Mon, 26 Jun 2017 13:36:56 -0400 In-Reply-To: <20170623140422.30320-1-seth.forshee@canonical.com> (Seth Forshee's message of "Fri, 23 Jun 2017 09:04:22 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 299 Lines: 11 Seth, > Both aac_send_raw_srb() and aac_get_hba_info() may copy stack > allocated structs to userspace without initializing all members of > these structs. Clear out this memory to prevent information leaks. Applied to 4.13/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering