Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751630AbdFZRn4 (ORCPT ); Mon, 26 Jun 2017 13:43:56 -0400 Received: from foss.arm.com ([217.140.101.70]:47484 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751308AbdFZRnv (ORCPT ); Mon, 26 Jun 2017 13:43:51 -0400 Subject: Re: [Devel] [PATCH v4 2/2] acpi, gicv3-its, numa: Adding numa node mapping for gic-its units To: Robert Richter References: <1498111812-17053-1-git-send-email-ganapatrao.kulkarni@cavium.com> <1498111812-17053-3-git-send-email-ganapatrao.kulkarni@cavium.com> <2d99c999-8ded-ac3d-57a2-fd81dbadadea@arm.com> <20170626173810.GW658@rric.localdomain> Cc: Ganapatrao Kulkarni , linux-acpi@vger.kernel.org, devel@acpica.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, lorenzo.pieralisi@arm.com, jason@lakedaemon.net, catalin.marinas@arm.com, jnair@caviumnetworks.com, will.deacon@arm.com, tglx@linutronix.de From: Marc Zyngier Organization: ARM Ltd Message-ID: <76d94864-d121-1d7a-bc23-00ac57cd7fb2@arm.com> Date: Mon, 26 Jun 2017 18:43:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170626173810.GW658@rric.localdomain> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1546 Lines: 44 On 26/06/17 18:38, Robert Richter wrote: > On 22.06.17 15:49:25, Marc Zyngier wrote: >> On 22/06/17 07:10, Ganapatrao Kulkarni wrote: >>> Add code to parse SRAT ITS Affinity sub table as defined in ACPI 6.2. >>> Later in per device probe, ITS devices are mapped to numa node using >>> ITS Id to proximity domain mapping. >>> >>> Signed-off-by: Ganapatrao Kulkarni >>> --- >>> drivers/irqchip/irq-gic-v3-its.c | 75 +++++++++++++++++++++++++++++++++++++++- >>> 1 file changed, 74 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c >>> index 45ea1933..1c21e01 100644 >>> --- a/drivers/irqchip/irq-gic-v3-its.c >>> +++ b/drivers/irqchip/irq-gic-v3-its.c >>> @@ -1833,6 +1833,77 @@ static int __init its_of_probe(struct device_node *node) >>> >>> #define ACPI_GICV3_ITS_MEM_SIZE (SZ_128K) >>> >>> +#ifdef CONFIG_ACPI_NUMA >> >> So given that there is a dependency issue between the irqchip and apcica >> trees, I plan on taking this patch with the following change: >> >> #if defined(CONFIG_ACPI_NUMA) && (ACPI_CA_VERSION >= 0x20170531) > > The struct name was changed :/ > > s/acpi_srat_its_affinity/acpi_srat_gic_its_affinity/ > > You need to update this too. I changed it when I applied the patch. See https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?h=irq/irqchip-4.13&id=dbd2b826723319eb6e4bee5214f8901e336c06be Which is also in tip/irq/core. Thanks, M. -- Jazz is not dead. It just smells funny...