Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751745AbdFZRoO (ORCPT ); Mon, 26 Jun 2017 13:44:14 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:26663 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbdFZRoG (ORCPT ); Mon, 26 Jun 2017 13:44:06 -0400 To: Christos Gkekas Cc: QLogic-Storage-Upstream@cavium.com, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: qedi: Remove comparison of u16 idx with zero. From: "Martin K. Petersen" Organization: Oracle Corporation References: <1498321485-21677-1-git-send-email-chris.gekas@gmail.com> Date: Mon, 26 Jun 2017 13:43:57 -0400 In-Reply-To: <1498321485-21677-1-git-send-email-chris.gekas@gmail.com> (Christos Gkekas's message of "Sat, 24 Jun 2017 17:24:45 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 197 Lines: 10 Christos, > Variable idx is defined as u16 thus statement (idx < 0) is always > false and should be removed. Applied to 4.13/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering