Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751461AbdFZRrL (ORCPT ); Mon, 26 Jun 2017 13:47:11 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.162]:35599 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317AbdFZRrF (ORCPT ); Mon, 26 Jun 2017 13:47:05 -0400 X-RZG-AUTH: :JGIXVUS7cutRB/49FwqZ7WcecEarQROEYabkiUo6mSAGQ+qKID8yPJWK6w== X-RZG-CLASS-ID: mo00 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH v1 2/6] [media] ov9650: add device tree support From: "H. Nikolaus Schaller" In-Reply-To: <20170626163102.GQ12407@valkosipuli.retiisi.org.uk> Date: Mon, 26 Jun 2017 19:46:34 +0200 Cc: Sylwester Nawrocki , Guennadi Liakhovetski , Rob Herring , Mark Rutland , Maxime Coquelin , Alexandre Torgue , Mauro Carvalho Chehab , Hans Verkuil , devicetree , linux-arm-kernel , LKML , linux-media@vger.kernel.org, Benjamin Gaignard , Yannick Fertre Message-Id: References: <1498143942-12682-1-git-send-email-hugues.fruchet@st.com> <1498143942-12682-3-git-send-email-hugues.fruchet@st.com> <20170626163102.GQ12407@valkosipuli.retiisi.org.uk> To: Sakari Ailus , Hugues Fruchet X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5QHlQ3F029940 Content-Length: 830 Lines: 27 Hi, > Am 26.06.2017 um 18:31 schrieb Sakari Ailus : > > Hi Hugues, > > On Thu, Jun 22, 2017 at 05:05:38PM +0200, Hugues Fruchet wrote: >> @@ -1545,15 +1577,22 @@ static int ov965x_remove(struct i2c_client *client) >> } >> >> static const struct i2c_device_id ov965x_id[] = { >> - { "OV9650", 0 }, >> - { "OV9652", 0 }, >> + { "OV9650", 0x9650 }, >> + { "OV9652", 0x9652 }, > > This change does not appear to match with the patch description nor it the > information is used. How about not changing it, unless there's a reason to? > The same for the data field of the of_device_id array below. I think it could/should be used to check if the camera chip that is found by reading the product-id and version registers does match what the device tree expects and abort probing on a mismatch. BR, Nikolaus