Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751450AbdFZSfz (ORCPT <rfc822;w@1wt.eu>);
        Mon, 26 Jun 2017 14:35:55 -0400
Received: from mail-io0-f195.google.com ([209.85.223.195]:36040 "EHLO
        mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751335AbdFZSfr (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 26 Jun 2017 14:35:47 -0400
Date: Mon, 26 Jun 2017 13:35:45 -0500
From: Rob Herring <robh@kernel.org>
To: Eddie James <eajames@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
        devicetree@vger.kernel.org, mark.rutland@arm.com,
        bradleyb@fuzziesquirrel.com, jk@ozlabs.org, cbostic@linux.vnet.ibm.com,
        joel@jms.id.au, andrew@aj.id.au,
        "Edward A. James" <eajames@us.ibm.com>
Subject: Re: [PATCH linux 4/4] drivers/fsi/occ: Add in-kernel API
Message-ID: <20170626183545.lalthvn4xufa52ww@rob-hp-laptop>
References: <1498073881-3207-1-git-send-email-eajames@linux.vnet.ibm.com>
 <1498073881-3207-5-git-send-email-eajames@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1498073881-3207-5-git-send-email-eajames@linux.vnet.ibm.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1722
Lines: 47

On Wed, Jun 21, 2017 at 02:38:01PM -0500, Eddie James wrote:
> From: "Edward A. James" <eajames@us.ibm.com>
> 
> Add an in-kernel read/write API with exported functions. This is
> necessary for other drivers which want to directly interact with the
> OCC. Also parse the OCC device tree node for child nodes and create
> child platform devices accordingly.
> 
> Signed-off-by: Edward A. James <eajames@us.ibm.com>
> ---
>  .../devicetree/bindings/fsi/ibm,p9-occ.txt         |   8 ++
>  drivers/fsi/occ.c                                  | 140 +++++++++++++++++----
>  include/linux/occ.h                                |  27 ++++
>  3 files changed, 154 insertions(+), 21 deletions(-)
>  create mode 100644 include/linux/occ.h
> 
> diff --git a/Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt b/Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt
> index 88002b9..71afba3 100644
> --- a/Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt
> +++ b/Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt
> @@ -6,10 +6,18 @@ Required properties:
>  
>  Optional properties:
>   - reg = <processor index>;	: index for the processor this OCC device is on
> + - <child nodes>		: Drivers for devices which communicate with
> +				  this OCC. Child nodes have no required or
> +				  optional properties that the OCC driver will
> +				  use.

Please put all the binding in a single, separate patch.

>  
>  Examples:
>  
>      occ@1 {
>          compatible = "ibm,p9-occ";
>          reg = <1>;
> +
> +	occ-hwmon@1 {
> +		compatible = "ibm,p9-occ-hwmon";
> +	};

This looks like you are creating a node just to instantiate a driver as 
hwmon is a Linuxism. Just have the parent OCC driver instantiate a hwmon 
driver.

Rob