Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752352AbdFZS5D (ORCPT ); Mon, 26 Jun 2017 14:57:03 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:35467 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752042AbdFZS4j (ORCPT ); Mon, 26 Jun 2017 14:56:39 -0400 Date: Mon, 26 Jun 2017 13:56:32 -0500 From: Rob Herring To: "H. Nikolaus Schaller" Cc: Hugues Fruchet , Mark Rutland , devicetree , Benjamin Gaignard , Discussions about the Letux Kernel , Alexandre Torgue , LKML , Hans Verkuil , Maxime Coquelin , Yannick Fertre , Sylwester Nawrocki , Mauro Carvalho Chehab , Guennadi Liakhovetski , linux-arm-kernel , linux-media@vger.kernel.org Subject: Re: [PATCH v1 1/6] DT bindings: add bindings for ov965x camera module Message-ID: <20170626185632.bfwuogm62ouo5y2j@rob-hp-laptop> References: <1498143942-12682-1-git-send-email-hugues.fruchet@st.com> <1498143942-12682-2-git-send-email-hugues.fruchet@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1214 Lines: 32 On Fri, Jun 23, 2017 at 12:25:33PM +0200, H. Nikolaus Schaller wrote: > Hi Hugues, > > > Am 22.06.2017 um 17:05 schrieb Hugues Fruchet : > > > > From: "H. Nikolaus Schaller" > > > > This adds documentation of device tree bindings > > for the OV965X family camera sensor module. > > > > Signed-off-by: H. Nikolaus Schaller > > Signed-off-by: Hugues Fruchet > > --- > > .../devicetree/bindings/media/i2c/ov965x.txt | 37 ++++++++++++++++++++++ > > 1 file changed, 37 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov965x.txt [...] > > +Optional Properties: > > +- resetb-gpios: reference to the GPIO connected to the resetb pin, if any. > > +- pwdn-gpios: reference to the GPIO connected to the pwdn pin, if any. > > Here I wonder why you did split that up into two gpios. Each "*-gpios" can have > multiple entries and if one is not used, a 0 can be specified to make it being ignored. > > But it is up to DT maintainers what they prefer: separate single gpios or a single gpio array. I think that is pretty clear if you survey a number of bindings (hint: it's the former). Rob