Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751544AbdFZUFE (ORCPT ); Mon, 26 Jun 2017 16:05:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:50674 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750819AbdFZUE7 (ORCPT ); Mon, 26 Jun 2017 16:04:59 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAC30217C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=snawrocki@kernel.org Subject: Re: [PATCH v1 1/6] DT bindings: add bindings for ov965x camera module To: Hugues FRUCHET , "H. Nikolaus Schaller" Cc: Guennadi Liakhovetski , Rob Herring , Mark Rutland , Maxime Coquelin , Alexandre TORGUE , Mauro Carvalho Chehab , Hans Verkuil , devicetree , linux-arm-kernel , LKML , "linux-media@vger.kernel.org" , Benjamin Gaignard , Yannick FERTRE , Discussions about the Letux Kernel References: <1498143942-12682-1-git-send-email-hugues.fruchet@st.com> <1498143942-12682-2-git-send-email-hugues.fruchet@st.com> <64e3005d-31df-71f2-762b-2c1b1152fc2d@st.com> From: Sylwester Nawrocki Message-ID: <5cd25a47-f3be-8c40-3940-29f26a245076@kernel.org> Date: Mon, 26 Jun 2017 22:04:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <64e3005d-31df-71f2-762b-2c1b1152fc2d@st.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1042 Lines: 30 On 06/26/2017 12:35 PM, Hugues FRUCHET wrote: >> What I am missing to support the GTA04 camera is the control of the optional "vana-supply". >> So the driver does not power up the camera module when needed and therefore probing fails. >> >> - vana-supply: a regulator to power up the camera module. >> >> Driver code is not complex to add: > Yes, I saw it in your code, but as I don't have any programmable power > supply on my setup, I have not pushed this commit. Since you are about to add voltage supplies to the DT binding I'd suggest to include all three voltage supplies of the sensor chip. Looking at the OV9650 and the OV9655 datasheet there are following names used for the voltage supply pins: AVDD - Analog power supply, DVDD - Power supply for digital core logic, DOVDD - Digital power supply for I/O. I doubt the sensor can work without any of these voltage supplies, thus regulator_get_optional() should not be used. I would just use the regulator bulk API to handle all three power supplies. -- Regards, Sylwester