Date: Mon, 26 Jun 2017 16:26:56 -0400
From: Keith Busch <keith.busch@intel.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: "luto@kernel.org" <luto@kernel.org>, "hch@lst.de" <hch@lst.de>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] nvme: explicitly disable APST on quirked devices
Message-ID: <20170626202656.GA23862@localhost.localdomain>
References: <20170626070129.14744-1-kai.heng.feng@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170626070129.14744-1-kai.heng.feng@canonical.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1070
Lines: 28

On Mon, Jun 26, 2017 at 12:01:29AM -0700, Kai-Heng Feng wrote:
> A user reports APST is enabled, even when the NVMe is quirked or with
> option "default_ps_max_latency_us=0".
> 
> The current logic will not set APST if the device is quirked. But the
> NVMe in question will enable APST automatically.
> 
> Separate the logic "apst is supported" and "to enable apst", so we can
> use the latter one to explicitly disable APST at initialiaztion.
> 
> BugLink: https://bugs.launchpad.net/bugs/1699004
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

There's something off about the format with this patch such that it is
getting mangled when I save and apply it.

I'm not sure if the content type and encoding are the culprit, but that
just stood out as different. Normally patches I receive have this header:

  Content-Type: text/plain; charset="us-ascii"
  Content-Transfer-Encoding: 7bit

But this one has:

  Content-Type: text/plain; charset="iso-8859-1"
  Content-Transfer-Encoding: quoted-printable

In any case, I'll hand apply it with Andy's review.