Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752128AbdFZUiR convert rfc822-to-8bit (ORCPT ); Mon, 26 Jun 2017 16:38:17 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:49458 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752026AbdFZUiP (ORCPT ); Mon, 26 Jun 2017 16:38:15 -0400 Date: Mon, 26 Jun 2017 21:38:07 +0100 User-Agent: K-9 Mail for Android In-Reply-To: <20170626181416.b7wr6wswuzeasuks@rob-hp-laptop> References: <1498055415-31513-1-git-send-email-fabrice.gasnier@st.com> <1498055415-31513-6-git-send-email-fabrice.gasnier@st.com> <20170626181416.b7wr6wswuzeasuks@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Subject: Re: [PATCH v2 5/8] dt-bindings: iio: Add STM32 LPTimer trigger binding To: Rob Herring , Fabrice Gasnier CC: lee.jones@linaro.org, benjamin.gaignard@linaro.org, jic23@kernel.org, thierry.reding@gmail.com, mark.rutland@arm.com, alexandre.torgue@st.com, mcoquelin.stm32@gmail.com, benjamin.gaignard@st.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org From: Jonathan Cameron Message-ID: <3D30F4CE-048C-4E5E-BDE1-48660B295066@jic23.retrosnub.co.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2201 Lines: 64 On 26 June 2017 19:14:16 BST, Rob Herring wrote: >On Wed, Jun 21, 2017 at 04:30:12PM +0200, Fabrice Gasnier wrote: >> Add documentation for STMicroelectronics STM32 Low-Power Timer >Trigger >> binding. >> >> Signed-off-by: Fabrice Gasnier >> --- >> Changes in v2: >> - s/Low Power/Low-Power >> - remove leading 0x in example (parent node) >> - improve reg property description >> --- >> .../bindings/iio/timer/stm32-lptimer-trigger.txt | 23 >++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> create mode 100644 >Documentation/devicetree/bindings/iio/timer/stm32-lptimer-trigger.txt >> >> diff --git >a/Documentation/devicetree/bindings/iio/timer/stm32-lptimer-trigger.txt >b/Documentation/devicetree/bindings/iio/timer/stm32-lptimer-trigger.txt >> new file mode 100644 >> index 0000000..466d99f >> --- /dev/null >> +++ >b/Documentation/devicetree/bindings/iio/timer/stm32-lptimer-trigger.txt >> @@ -0,0 +1,23 @@ >> +STMicroelectronics STM32 Low-Power Timer Trigger >> + >> +STM32 Low-Power Timer provides trigger source (LPTIM output) that >can be used >> +by STM32 internal ADC and/or DAC. >> + >> +Must be a sub-node of an STM32 Low-Power Timer device tree node. >> +See ../mfd/stm32-lptimer.txt for details about the parent node. >> + >> +Required properties: >> +- compatible: Must be "st,stm32-lptimer-trigger". >> +- reg: Selects trigger hardware block. Must be 0, 1 or 2 >> + respectively for lptimer1, lptimer2 or lptimer3 >> + trigger output. > >I guess this answers my question. However, this seems like abuse of the > >reg prop. This should not be how you select a trigger. The DT should >describe all the h/w blocks and then the adc connection is a separate >property. I think this is miss described. Reg is labelling instances of the hardware block which is providing the trigger. The connection to an ADC etc is done from userspace. > >Rob >-- >To unsubscribe from this list: send the line "unsubscribe linux-iio" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html -- Sent from my Android device with K-9 Mail. Please excuse my brevity.