Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752070AbdFZViB (ORCPT ); Mon, 26 Jun 2017 17:38:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56436 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751403AbdFZVhy (ORCPT ); Mon, 26 Jun 2017 17:37:54 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 95F2974859 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jeyu@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 95F2974859 Date: Mon, 26 Jun 2017 23:37:36 +0200 From: Jessica Yu To: Kees Cook Cc: "Luis R. Rodriguez" , Andrew Morton , Shuah Khan , Rusty Russell , "Eric W. Biederman" , Dmitry Torokhov , Arnaldo Carvalho de Melo , Jonathan Corbet , Josh Triplett , martin.wilck@suse.com, Michal Marek , Petr Mladek , hare , rwright@hpe.com, Jeff Mahoney , David Sterba , Filipe Manana , NeilBrown , Guenter Roeck , rgoldwyn@suse.com, Subash Abhinov Kasiviswanathan , Heinrich Schuchardt , Aaron Tomlin , Miroslav Benes , "Paul E. McKenney" , Dan Williams , Josh Poimboeuf , "David S. Miller" , Ingo Molnar , Alan Cox , "Ted Ts'o" , Greg KH , Linus Torvalds , linux-kselftest@vger.kernel.org, "linux-doc@vger.kernel.org" , LKML Subject: Re: [PATCH v3 0/4] kmod: help make deterministic Message-ID: <20170626213735.fp34vx7mvbtopzz6@redbean> References: <20170526001630.19203-1-mcgrof@kernel.org> <20170526211228.27764-1-mcgrof@kernel.org> <20170620205622.GX21846@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-OS: Linux redbean 4.11.5-200.fc25.x86_64 x86_64 User-Agent: NeoMutt/20170609 (1.8.3) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 26 Jun 2017 21:37:54 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1953 Lines: 44 +++ Kees Cook [20/06/17 17:23 -0700]: >On Tue, Jun 20, 2017 at 1:56 PM, Luis R. Rodriguez wrote: >> On Fri, May 26, 2017 at 02:12:24PM -0700, Luis R. Rodriguez wrote: >>> This v3 nukes the proc sysctl interface in favor for just letting userspace >>> just check kernel revision. Prior to whenever this is merged userspace should >>> try to avoid hammering more than 50 kmod threads as they can fail and it'd >>> get -ENOMEM. >>> >>> We do away with the old heuristics on assuming you could end up with >>> less than max_threads/2 < 50 threads as Dmitry notes this would mean having >>> a system with 16 MiB of RAM with modules enabled. It simplifies our patch >>> "kmod: reduce atomic operations on kmod_concurrent" considerbly. >>> >>> Since the sysctl interface is gone, this no longer depends on any >>> other patches, the series is independent. As usual the series is >>> available on my linux-next 20170526-kmod-only branch which is based >>> on next-20170526. >>> >>> [0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20170526-kmod-only >>> >>> Luis >>> >>> Luis R. Rodriguez (4): >>> module: use list_for_each_entry_rcu() on find_module_all() >>> kmod: reduce atomic operations on kmod_concurrent and simplify >>> kmod: add test driver to stress test the module loader >>> kmod: throttle kmod thread limit >> >> About a month now with no further nitpicks. What tree should these changes >> go through if there are no issues? Andrew's, Jessica's ? > >Seems like going through Jessica's would make the most sense? Would be happy to take patches 01 (which I need to anyway), 02, possibly 04 if decoupled from the test driver (03). I can't take patch 03 through my tree just yet, as I haven't had time to give it a look yet :-/ [ Side comment, it seems that kmod.c isn't directly maintained by anyone right now, perhaps Luis would be interested in picking it up? :-) ] Thanks, Jessica