Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752055AbdFZW5a (ORCPT ); Mon, 26 Jun 2017 18:57:30 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:55882 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751520AbdFZWtt (ORCPT ); Mon, 26 Jun 2017 18:49:49 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 19C1A60724 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Mon, 26 Jun 2017 15:49:46 -0700 From: Stephen Boyd To: Paul Cercueil Cc: Ralf Baechle , Michael Turquette , Rob Herring , Paul Burton , Maarten ter Huurne , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 04/15] clk: Add Ingenic jz4770 CGU driver Message-ID: <20170626224946.GR4493@codeaurora.org> References: <20170607200439.24450-1-paul@crapouillou.net> <20170607200439.24450-5-paul@crapouillou.net> <20170607205943.GO20170@codeaurora.org> <639b492cc57200bab14572ac591ef8af@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <639b492cc57200bab14572ac591ef8af@crapouillou.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1191 Lines: 37 On 06/26, Paul Cercueil wrote: > Hi, > > Le 2017-06-07 22:59, Stephen Boyd a ?crit?: > >On 06/07, Paul Cercueil wrote: > >>Add support for the clocks provided by the CGU in the Ingenic JZ4770 > >>SoC. > >> > >>Signed-off-by: Paul Cercueil > >>Signed-off-by: Maarten ter Huurne > > [...] > > >>diff --git a/include/dt-bindings/clock/jz4770-cgu.h > >>b/include/dt-bindings/clock/jz4770-cgu.h > >>new file mode 100644 > >>index 000000000000..54b8b2ae4a73 > >>--- /dev/null > >>+++ b/include/dt-bindings/clock/jz4770-cgu.h > > > >Can you split this file off into a different patch? That way clk > >tree can apply clk patches on top of a stable branch where this > >file lives by itself. > > Oops, I forgot that in the v2. > > The jz4770-cgu.c file includes and uses > , so I don't think > it would make sense to split it, since it wouldn't compile without it. I was suggesting this header file be a patch before the driver C file patch, so that it would still compile. Does that change anything? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project