DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7AC7980468
Date: Tue, 27 Jun 2017 00:58:29 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Thomas Richter <tmricht@linux.vnet.ibm.com>
Cc: acme@kernel.org, linux-kernel@vger.kernel.org,
        linux-s390@vger.kernel.org, brueckner@linux.vnet.ibm.com
Subject: Re: [PATCH] [PATCH v2] perf test: add platform dependency to test 15
Message-ID: <20170626225828.GA19984@krava>
References: <20170622073625.86762-1-tmricht@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170622073625.86762-1-tmricht@linux.vnet.ibm.com>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2312
Lines: 69

On Thu, Jun 22, 2017 at 09:36:25AM +0200, Thomas Richter wrote:
> This patch adds platform dependency into the
> test case 15 (perf_event_attr). It is based on a suggestion from
> Jiri Olsa.
> Add a new optional attribute named 'arch' in the [config] section
> of the test case file. It is a comma separated list of architecture
> names this test can be executed on. For example:
> 
> arch = x86_64,alpha,ppc
> 
> If this attribute is missing the test is executed on any platform.
> This does not break existing behavior.
> The values listed for this attribute should be identical to
> uname -m output.
> If the list starts with an exclamation mark (!) the comparison is
> inverted, for example for
> 
> arch = !s390x,ppc
> 
> the test is not executed on s390x or ppc platforms.
> The exclamation mark must be at the beginnning of the list.
> 
> Here is an example debug output:
> [root@s35lp76]# fgrep arch tests/attr/test-stat-C2
> arch = x86_64,alpha,ppc
> [root@s35lp76]# PERF_TEST_ATTR=/tmp /usr/bin/python2 ./tests/attr.py \
>   -d ./tests/attr/ -p ./perf -vvvvv -t test-stat-C1
> 
> provides the following output:
> 
> running './tests/attr//test-stat-C1'
> test limitation 'x86_64,alpha,ppc' <--- new
>   loading expected events
>     Event event:base-stat
>       fd = 1
>       group_fd = -1
>       .....
> 
> Here is the output when a test is skipped:
> [root@s35lp76]# fgrep arch tests/attr/test-stat-C1
> arch = !s390x
> [root@s35lp76]# PERF_TEST_ATTR=/tmp /usr/bin/python2 ./tests/attr.py \
>   -d ./tests/attr/ -p ./perf -vvvvv -t test-stat-C1
> 
> provides the following output:
> test limitation '!s390x' <--- new
> 
> skipped [s390x] './tests/attr//test-stat-C1' <--- new
> 
> The test is skipped with return code 0.
> 
> Suggested-by: Jiri Olsa <jolsa@redhat.com>
> Signed-off-by: Thomas Richter <tmricht@linux.vnet.ibm.com>
> Reviewed-by: Jiri Olsa <jolsa@redhat.com>
> Reviwed-by: Arnaldo Carvalho de Melo <acme@kernel.org>

Acked-by: Jiri Olsa <jolsa@redhat.com>

sorry for delay, I finished my attr tests fixes, you can check
them in my perf/attr_test_2 branch.. still need to write changelogs ;-)

it passes for me now, however we still might need few fixes
due to different HW and supported events.. could you please
test that on your system?

I'll post the changes soon

thanks,
jirka