Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751875AbdFZXMb (ORCPT ); Mon, 26 Jun 2017 19:12:31 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:34664 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751445AbdFZXMa (ORCPT ); Mon, 26 Jun 2017 19:12:30 -0400 Date: Tue, 27 Jun 2017 07:12:26 +0800 From: Wei Yang To: Borislav Petkov Cc: Wei Yang , kirill@shutemov.name, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, tj@kernel.org, rientjes@google.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 2/3] x86/numa_emulation: assign physnode_mask directly from numa_nodes_parsed Message-ID: <20170626231226.GB53180@WeideMacBook-Pro.local> Reply-To: Wei Yang References: <20170502130453.5933-1-richard.weiyang@gmail.com> <20170502130453.5933-3-richard.weiyang@gmail.com> <20170626184026.eztcwsqfy3yu7fvh@pd.tnic> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/WwmFnJnmDyWGHa4" Content-Disposition: inline In-Reply-To: <20170626184026.eztcwsqfy3yu7fvh@pd.tnic> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2603 Lines: 80 --/WwmFnJnmDyWGHa4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 26, 2017 at 08:40:26PM +0200, Borislav Petkov wrote: >On Tue, May 02, 2017 at 09:04:52PM +0800, Wei Yang wrote: >> numa_init() has already called init_func(), which is responsible for >> setting numa_nodes_parsed, so use this nodemask instead of re-finding it >> when calling numa_emulation(). >>=20 >> This patch gets the physnode_mask directly from numa_nodes_parsed. At >> the same time, it corrects the comment of these two functions. >>=20 >> Signed-off-by: Wei Yang >> Acked-by: David Rientjes >>=20 >> --- >> v2: refresh the change log based on David Rientjes comment >> --- >> arch/x86/mm/numa_emulation.c | 18 ++++++++---------- >> 1 file changed, 8 insertions(+), 10 deletions(-) >>=20 >> diff --git a/arch/x86/mm/numa_emulation.c b/arch/x86/mm/numa_emulation.c >> index eb017c816de6..a6d01931b9a1 100644 >> --- a/arch/x86/mm/numa_emulation.c >> +++ b/arch/x86/mm/numa_emulation.c >> @@ -75,13 +75,15 @@ static int __init emu_setup_memblk(struct numa_memin= fo *ei, >> =20 >> /* >> * Sets up nr_nodes fake nodes interleaved over physical nodes ranging = =66rom addr >> - * to max_addr. The return value is the number of nodes allocated. >> + * to max_addr. >> + * >> + * Returns zero on success or negative error code. > > ... on error. > >Other than that: > >Reviewed-by: Borislav Petkov > Thanks >--=20 >Regards/Gruss, > Boris. > >Good mailing practices for 400: avoid top-posting and trim the reply. --=20 Wei Yang Help you, Help me --/WwmFnJnmDyWGHa4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZUZTaAAoJEKcLNpZP5cTdfWkP/2OHTvvZvu6td5m/jZB9FBeW P2No3PAVnvW3R41/arg7N6Bk/1TMKoGcKuq4sCz0FCYvc9qKyZy/wjpsUNiCrAUM SuiI0ImWsZ7ZNcp4WhYmrJmxwZbHAp7ThKPaxQQdfftXnkMaYxLiSeWRBnNh+L5e 6f1yaLYg+/75pyjY5JqKP0KTOa6dcgmTRszFqD61Dy/cHW6J+UvDin8205XHBQG7 nrW73yvlD2y6fntsijkOt58R4EAPXsTxl/Mr6K9c5XYtMJ6y3Jytx8EiwsATZJuv Kr6z8NGh/OjAJ1wMUAew1LIeI2dHlheHFUV6IbciRXeB0AgR4Cavj3rpndGu8N5y /1YM6iREiCUZ3ORH4YIvTwI6ukn1G+4Igw6it9rQFyGKI8V3MK2TgcY2zMdSiqgS M0zSHnFJwfcwFg3NoXhopjS9Npm3Df9+y6Rliwh1hsPxthFyzn0MQICIko6lOwcy Dv4cTA3HrvP5Zv29vIrF4Hqarz9P0cX47SDs7hLAWLm7RrJY+9XRQyoypZVnlCgB gQ28gUZPqtkA6mNBsWZxSH20Ma3GaFVQDLeHvp4RbkTefbcr/YMsbU4ObyiCVFmE 1PeZ5pN6HXPDya6w856DdVdqpKsus1AJ+N1bVjqVo/chAVcsq/6J39TW91FuoPv5 KPr74PyhHhk/ulTi8ALz =qwWP -----END PGP SIGNATURE----- --/WwmFnJnmDyWGHa4--