Date: Tue, 27 Jun 2017 01:41:07 +0200
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>,
        Ming Lei <ming.lei@redhat.com>, yi1.li@linux.intel.com,
        takahiro.akashi@linaro.org, nbroeking@me.com,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>, mfuzzey@parkeon.com,
        ebiederm@xmission.com, dmitry.torokhov@gmail.com, wagi@monom.org,
        dwmw2@infradead.org, jewalt@lgsinnovations.com, rafal@milecki.pl,
        arend.vanspriel@broadcom.com, rjw@rjwysocki.net, atull@kernel.org,
        moritz.fischer@ettus.com, pmladek@suse.com, johannes.berg@intel.com,
        emmanuel.grumbach@intel.com, luciano.coelho@intel.com, luto@kernel.org,
        torvalds@linux-foundation.org, keescook@chromium.org,
        dhowells@redhat.com, pjones@redhat.com, hdegoede@redhat.com,
        alan@linux.intel.com, tytso@mit.edu, paul.gortmaker@windriver.com,
        mtosatti@redhat.com, mawilcox@microsoft.com, stephen.boyd@linaro.org,
        markivx@codeaurora.org, linux-kernel@vger.kernel.org,
        Tom Gundersen <teg@jklm.no>, oss-drivers@netronome.com
Subject: Re: [PATCH] firmware: wake all waiters
Message-ID: <20170626234107.GJ21846@wotan.suse.de>
References: <20170623233702.20564-1-jakub.kicinski@netronome.com>
 <20170626212036.GE21846@wotan.suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170626212036.GE21846@wotan.suse.de>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1226
Lines: 23

On Mon, Jun 26, 2017 at 11:20:36PM +0200, Luis R. Rodriguez wrote:
> On Fri, Jun 23, 2017 at 04:37:02PM -0700, Jakub Kicinski wrote:
> There's a slew of bugs lurking here though!
> 
> As noted the reported Intel driver issues still need other fixes, one was the
> fw_state_done() on the direct filesystem lookup mechanism [1], and that may be
> a regression since direct filesystem loading was added, and even secondary
> requests would seem to just wait forever (MAX_SCHEDULE_TIMEOUT); the combination
> of both fixes should fix your reported issue.

Actually fw_state_done() is already called on success on direct filesystem loading,
so that should be fine. The bug report proposed change only adds a fw_state_aborted()
in case of a failure on direct fs lookups. That in turn, needs consideration of the
fallback mechanism, ie, only in case of *real* final falure should fw_state_aborte()
be issued. Distros that have enabled the fallback mechanism (seems like andoid now)
have no other option but to wait for the fallback mechanism or timeout to complete.

Its one reason why the firmwared thing is a good thing to review which has the
best-effort mode and final-mode [0].

[0] https://github.com/teg/firmwared.git

  Luis