Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751550AbdF0A1y (ORCPT ); Mon, 26 Jun 2017 20:27:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:49986 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751456AbdF0A1s (ORCPT ); Mon, 26 Jun 2017 20:27:48 -0400 Date: Tue, 27 Jun 2017 02:27:44 +0200 From: "Luis R. Rodriguez" To: Jessica Yu , Linus Torvalds , Peter Zijlstra Cc: Jessica Yu , Kees Cook , "Luis R. Rodriguez" , Andrew Morton , Shuah Khan , Rusty Russell , "Eric W. Biederman" , Dmitry Torokhov , Arnaldo Carvalho de Melo , Jonathan Corbet , Josh Triplett , martin.wilck@suse.com, Michal Marek , Petr Mladek , hare , rwright@hpe.com, Jeff Mahoney , David Sterba , Filipe Manana , NeilBrown , Guenter Roeck , rgoldwyn@suse.com, Subash Abhinov Kasiviswanathan , Heinrich Schuchardt , Aaron Tomlin , Miroslav Benes , "Paul E. McKenney" , Dan Williams , Josh Poimboeuf , "David S. Miller" , Ingo Molnar , Alan Cox , "Ted Ts'o" , Greg KH , linux-kselftest@vger.kernel.org, "linux-doc@vger.kernel.org" , LKML Subject: Re: [PATCH v3 0/4] kmod: help make deterministic Message-ID: <20170627002744.GP21846@wotan.suse.de> References: <20170526001630.19203-1-mcgrof@kernel.org> <20170526211228.27764-1-mcgrof@kernel.org> <20170620205622.GX21846@wotan.suse.de> <20170626213735.fp34vx7mvbtopzz6@redbean> <20170626224442.GH21846@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170626224442.GH21846@wotan.suse.de> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1604 Lines: 32 On Tue, Jun 27, 2017 at 12:44:42AM +0200, Luis R. Rodriguez wrote: > On Mon, Jun 26, 2017 at 11:37:36PM +0200, Jessica Yu wrote: > > +++ Kees Cook [20/06/17 17:23 -0700]: > > > On Tue, Jun 20, 2017 at 1:56 PM, Luis R. Rodriguez wrote: > > > > On Fri, May 26, 2017 at 02:12:24PM -0700, Luis R. Rodriguez wrote: > > > > > Luis R. Rodriguez (4): > > > > > module: use list_for_each_entry_rcu() on find_module_all() > > > > > kmod: reduce atomic operations on kmod_concurrent and simplify > > > > > kmod: add test driver to stress test the module loader > > > > > kmod: throttle kmod thread limit > > > > > > > > About a month now with no further nitpicks. What tree should these changes > > > > go through if there are no issues? Andrew's, Jessica's ? > > > > > > Seems like going through Jessica's would make the most sense? > > > > Would be happy to take patches 01 (which I need to anyway), 02, > > possibly 04 if decoupled from the test driver (03). > > Feel free to decouple it, but note that then the commit log must then be > changed. My own take is this fix is not so critical as it is a corner case, so > I have instead preferred to couple in the test case and respective fix > together. I'll leave it up to you how to proceed. Note: Linus noted swait is actually very special use-case [0] so I'd hate to add a new use case not vetted for. This use case on kmod.c really does *not* require anything but a simple wait though, so really am inclined to let that through unless I hear back... [0] https://lkml.kernel.org/r/20170627001534.GK21846@wotan.suse.de Luis