Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751498AbdF0Aok (ORCPT ); Mon, 26 Jun 2017 20:44:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:43782 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751453AbdF0Aoe (ORCPT ); Mon, 26 Jun 2017 20:44:34 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0C0622BD2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Mon, 26 Jun 2017 21:44:30 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Thomas Richter , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, brueckner@linux.vnet.ibm.com Subject: Re: [PATCH] [PATCH v2] perf test: add platform dependency to test 15 Message-ID: <20170627004430.GA16387@kernel.org> References: <20170622073625.86762-1-tmricht@linux.vnet.ibm.com> <20170626225828.GA19984@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170626225828.GA19984@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2520 Lines: 71 Em Tue, Jun 27, 2017 at 12:58:29AM +0200, Jiri Olsa escreveu: > On Thu, Jun 22, 2017 at 09:36:25AM +0200, Thomas Richter wrote: > > This patch adds platform dependency into the > > test case 15 (perf_event_attr). It is based on a suggestion from > > Jiri Olsa. > > Add a new optional attribute named 'arch' in the [config] section > > of the test case file. It is a comma separated list of architecture > > names this test can be executed on. For example: > > > > arch = x86_64,alpha,ppc > > > > If this attribute is missing the test is executed on any platform. > > This does not break existing behavior. > > The values listed for this attribute should be identical to > > uname -m output. > > If the list starts with an exclamation mark (!) the comparison is > > inverted, for example for > > > > arch = !s390x,ppc > > > > the test is not executed on s390x or ppc platforms. > > The exclamation mark must be at the beginnning of the list. > > > > Here is an example debug output: > > [root@s35lp76]# fgrep arch tests/attr/test-stat-C2 > > arch = x86_64,alpha,ppc > > [root@s35lp76]# PERF_TEST_ATTR=/tmp /usr/bin/python2 ./tests/attr.py \ > > -d ./tests/attr/ -p ./perf -vvvvv -t test-stat-C1 > > > > provides the following output: > > > > running './tests/attr//test-stat-C1' > > test limitation 'x86_64,alpha,ppc' <--- new > > loading expected events > > Event event:base-stat > > fd = 1 > > group_fd = -1 > > ..... > > > > Here is the output when a test is skipped: > > [root@s35lp76]# fgrep arch tests/attr/test-stat-C1 > > arch = !s390x > > [root@s35lp76]# PERF_TEST_ATTR=/tmp /usr/bin/python2 ./tests/attr.py \ > > -d ./tests/attr/ -p ./perf -vvvvv -t test-stat-C1 > > > > provides the following output: > > test limitation '!s390x' <--- new > > > > skipped [s390x] './tests/attr//test-stat-C1' <--- new > > > > The test is skipped with return code 0. > > > > Suggested-by: Jiri Olsa > > Signed-off-by: Thomas Richter > > Reviewed-by: Jiri Olsa > > Reviwed-by: Arnaldo Carvalho de Melo > > Acked-by: Jiri Olsa > > sorry for delay, I finished my attr tests fixes, you can check > them in my perf/attr_test_2 branch.. still need to write changelogs ;-) > > it passes for me now, however we still might need few fixes > due to different HW and supported events.. could you please > test that on your system? > > I'll post the changes soon Thanks, applied. - Arnaldo