Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752037AbdF0CQj (ORCPT ); Mon, 26 Jun 2017 22:16:39 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:51779 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751471AbdF0CQb (ORCPT ); Mon, 26 Jun 2017 22:16:31 -0400 Subject: Re: [1/2] drivers/watchdog: Document new aspeed optional dev tree properties. To: Guenter Roeck References: <20170613203818.17399-2-cbostic@linux.vnet.ibm.com> <20170624220722.GA3621@roeck-us.net> Cc: wim@iguana.be, joel@jms.id.au, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, andrew@aj.id.au From: Christopher Bostic Date: Mon, 26 Jun 2017 21:16:22 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170624220722.GA3621@roeck-us.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17062702-0024-0000-0000-0000029F11CB X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007283; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000214; SDB=6.00879215; UDB=6.00438177; IPR=6.00659369; BA=6.00005443; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015963; XFM=3.00000015; UTC=2017-06-27 02:16:30 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17062702-0025-0000-0000-000044892C35 Message-Id: <962762c7-6baf-4116-d9d3-32b5ebe6b3c9@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-26_18:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706270034 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1997 Lines: 55 On 6/24/17 5:07 PM, Guenter Roeck wrote: > On Tue, Jun 13, 2017 at 03:38:17PM -0500, Christopher Bostic wrote: >> Describe new optional property 'external-signal'. When present in the >> system device tree an exernal signal is generated on watchdog timeout. >> >> Describe new optional property 'no-system-reset'. When present in the >> system device tree no system reset is to occur on watchdog timeout. >> System reset in this case is managed by one of the other watchogs >> available. >> >> Signed-off-by: Christopher Bostic > This requires DT maintainer approval, but DT maintainers were not copied. > Please resend and use scripts/get_maintainer.pl to determine who to send > it to. > > Guenter Hi Guenter, Will resend with maintainers copied. Thanks -Chris >> --- >> Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt >> index c5e74d7..4099ea5 100644 >> --- a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt >> +++ b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt >> @@ -8,9 +8,20 @@ Required properties: >> - reg: physical base address of the controller and length of memory mapped >> region >> >> +Optional properties: >> + - external-signal: If the property is present then an external signal is to >> + be generated on watchdog timeout. If absent, external signal is not >> + generated. >> + >> + - no-system-reset: If the property is present then system will not be reset >> + on watchdog timeout. In this case one of the other watchdogs will handle >> + reset. If absent then the watchdog resets the system on timeout. >> + >> Example: >> >> wdt1: watchdog@1e785000 { >> compatible = "aspeed,ast2400-wdt"; >> reg = <0x1e785000 0x1c>; >> + external-signal; >> + no-system-reset; >> };