Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752606AbdF0KnZ (ORCPT ); Tue, 27 Jun 2017 06:43:25 -0400 Received: from mx2.mpynet.fi ([82.197.21.85]:59056 "EHLO mx2.mpynet.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751632AbdF0KnT (ORCPT ); Tue, 27 Jun 2017 06:43:19 -0400 Date: Tue, 27 Jun 2017 13:43:17 +0300 From: Rakesh Pandit To: Jens Axboe , Matias =?iso-8859-1?Q?Bj=F8rling?= CC: , , Matias =?iso-8859-1?Q?Bj=F8rling?= , Frans Klaver , Javier =?iso-8859-1?Q?Gonz=E1lez?= Subject: [PATCH V2] lightnvm: if LUNs are already allocated fix return Message-ID: <20170627104315.GA52146@dhcp-216.srv.tuxera.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline User-Agent: Mutt/1.7.1 (2016-10-04) X-ClientProxiedBy: tuxera-exch.ad.tuxera.com (10.20.48.11) To tuxera-exch.ad.tuxera.com (10.20.48.11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 911 Lines: 28 While creating new device with NVM_DEV_CREATE if LUNs are already allocated ioctl would return -ENOMEM which is wrong. This patch propagates -EBUSY from nvm_reserve_luns which is correct response. Fixes: ade69e243 ("lightnvm: merge gennvm with core") Signed-off-by: Rakesh Pandit --- V2: return error code directly instead of using ret variable (Frans) drivers/lightnvm/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c index b8f82f5..c5d71c6 100644 --- a/drivers/lightnvm/core.c +++ b/drivers/lightnvm/core.c @@ -253,7 +253,7 @@ static int nvm_create_tgt(struct nvm_dev *dev, struct nvm_ioctl_create *create) mutex_unlock(&dev->mlock); if (nvm_reserve_luns(dev, s->lun_begin, s->lun_end)) - return -ENOMEM; + return -EBUSY; t = kmalloc(sizeof(struct nvm_target), GFP_KERNEL); if (!t) { -- 2.5.5