Date: Tue, 27 Jun 2017 14:23:44 +0300
From: Rakesh Pandit <rakesh@tuxera.com>
To: Frans Klaver <fransklaver@gmail.com>
CC: Jens Axboe <axboe@fb.com>,
        Matias =?iso-8859-1?Q?Bj=F8rling?= <m@bjorling.me>,
        <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Matias =?iso-8859-1?Q?Bj=F8rling?= <matias@cnexlabs.com>,
        Javier =?iso-8859-1?Q?Gonz=E1lez?= <jg@lightnvm.io>
Subject: Re: [PATCH V2] lightnvm: if LUNs are already allocated fix return
Message-ID: <20170627112344.GA52927@dhcp-216.srv.tuxera.com>
References: <20170627104315.GA52146@dhcp-216.srv.tuxera.com>
 <CAH6sp9MMAenKxknXYkCwOY9H7h_CT9zkBTvrykssVMPOdGtzqQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CAH6sp9MMAenKxknXYkCwOY9H7h_CT9zkBTvrykssVMPOdGtzqQ@mail.gmail.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1290
Lines: 31

On Tue, Jun 27, 2017 at 01:01:22PM +0200, Frans Klaver wrote:
> On Tue, Jun 27, 2017 at 12:43 PM, Rakesh Pandit <rakesh@tuxera.com> wrote:
> > While creating new device with NVM_DEV_CREATE if LUNs are already
> > allocated ioctl would return -ENOMEM which is wrong.  This patch
> > propagates -EBUSY from nvm_reserve_luns which is correct response.
> >
> > Fixes: ade69e243 ("lightnvm: merge gennvm with core")
> > Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
> > ---
> >
> > V2: return error code directly instead of using ret variable (Frans)
> >
> >  drivers/lightnvm/core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
> > index b8f82f5..c5d71c6 100644
> > --- a/drivers/lightnvm/core.c
> > +++ b/drivers/lightnvm/core.c
> > @@ -253,7 +253,7 @@ static int nvm_create_tgt(struct nvm_dev *dev, struct nvm_ioctl_create *create)
> >         mutex_unlock(&dev->mlock);
> >
> >         if (nvm_reserve_luns(dev, s->lun_begin, s->lun_end))
> > -               return -ENOMEM;
> > +               return -EBUSY;
> 
> Why aren't you propagating ret in this version?

Well nvm_reserve_luns either returns 0 or -EBUSY and it is unlikely
that return value would change and even if it does this can be
updated.