Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752936AbdF0MGj (ORCPT ); Tue, 27 Jun 2017 08:06:39 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:34298 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751574AbdF0MGh (ORCPT ); Tue, 27 Jun 2017 08:06:37 -0400 Date: Tue, 27 Jun 2017 15:06:26 +0300 From: Roman Storozhenko To: kvm@vger.kernel.org Cc: christoffer.dall@linaro.org, marc.zyngier@arm.com, pbonzini@redhat.com, rkrcmar@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: Replaces 'unsigned' with 'unsigned int' in the codebase Message-ID: <20170627120626.GA21666@home> Reply-To: "'Roman Storozhenko" , '@home References: <20170627095401.GA19864@home> <9b50ee4b-d27a-8872-0cd3-cad8f5f0e0f8@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9b50ee4b-d27a-8872-0cd3-cad8f5f0e0f8@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 842 Lines: 24 On Tue, Jun 27, 2017 at 12:01:25PM +0200, Paolo Bonzini wrote: > > > On 27/06/2017 11:54, Roman Storozhenko wrote: > > Signed-off-by: Roman Storozhenko > > --- > > virt/kvm/arm/arm.c | 2 +- > > virt/kvm/coalesced_mmio.c | 2 +- > > virt/kvm/eventfd.c | 10 ++++++---- > > virt/kvm/irqchip.c | 7 ++++--- > > virt/kvm/kvm_main.c | 16 ++++++++-------- > > 5 files changed, 20 insertions(+), 17 deletions(-) > > This change is pointless. Contributors to KVM should know what > "unsigned" means. Paolo, thanks that you mentioned this. But I have a question - is this just useless or this is an error? I saw many places in the codebase where 'unsigned int' is used. That why I decided to make the codebase more standartized from the style point of view. Thanks, Roman Storozhenko.