Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752855AbdF0MVl (ORCPT <rfc822;w@1wt.eu>);
        Tue, 27 Jun 2017 08:21:41 -0400
Received: from smtprelay0026.hostedemail.com ([216.40.44.26]:50492 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1751453AbdF0MVe (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 27 Jun 2017 08:21:34 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4250:4321:4605:5007:6119:7514:7903:8700:10004:10400:10848:11232:11658:11914:12740:12760:12895:13069:13311:13357:13439:14096:14097:14181:14659:14721:21080:21434:21627:30041:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:6,LUA_SUMMARY:none
X-HE-Tag: spade99_d5ba78751454
X-Filterd-Recvd-Size: 2285
Message-ID: <1498566090.24295.59.camel@perches.com>
Subject: Re: [PATCH] KVM: Replaces 'unsigned' with 'unsigned int' in the
 codebase
From: Joe Perches <joe@perches.com>
To: "'Roman Storozhenko" <romeusmeister@gmail.com>, '@home,
        kvm@vger.kernel.org
Cc: christoffer.dall@linaro.org, marc.zyngier@arm.com, pbonzini@redhat.com,
        rkrcmar@redhat.com, linux-arm-kernel@lists.infradead.org,
        kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org
Date: Tue, 27 Jun 2017 05:21:30 -0700
In-Reply-To: <20170627120626.GA21666@home>
References: <20170627095401.GA19864@home>
         <9b50ee4b-d27a-8872-0cd3-cad8f5f0e0f8@redhat.com>
         <20170627120626.GA21666@home>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.22.6-1ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1263
Lines: 31

On Tue, 2017-06-27 at 15:06 +0300, Roman Storozhenko wrote:
> On Tue, Jun 27, 2017 at 12:01:25PM +0200, Paolo Bonzini wrote:
> > On 27/06/2017 11:54, Roman Storozhenko wrote:
> > > Signed-off-by: Roman Storozhenko <romeusmeister@gmail.com>
> > > ---
> > >  virt/kvm/arm/arm.c        |  2 +-
> > >  virt/kvm/coalesced_mmio.c |  2 +-
> > >  virt/kvm/eventfd.c        | 10 ++++++----
> > >  virt/kvm/irqchip.c        |  7 ++++---
> > >  virt/kvm/kvm_main.c       | 16 ++++++++--------
> > >  5 files changed, 20 insertions(+), 17 deletions(-)
> > 
> > This change is pointless.  Contributors to KVM should know what
> > "unsigned" means.
> 
> Paolo, thanks that you mentioned this. But I have a question - is this just
> useless or this is an error?

(Not Paulo and my 2c) Neither really.

> I saw many places in the codebase where 'unsigned int' is used. That why I
> decided to make the codebase more standartized from the style point of
> view.

In virt/kvm, there are 16 lines with unsigned, 160 with unsigned int

<shrug>, Both statements are correct, yes, it's kinda pointless,
and, yes, it does standardize the declarations.

It's entirely up the the maintainers (Paulo and Radim) to apply
or reject this style-only trivial patch.  The compiler doesn't care.