Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753352AbdF0Mym (ORCPT <rfc822;w@1wt.eu>);
        Tue, 27 Jun 2017 08:54:42 -0400
Received: from mga14.intel.com ([192.55.52.115]:46242 "EHLO mga14.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752962AbdF0Myk (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 27 Jun 2017 08:54:40 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.39,399,1493708400"; 
   d="scan'208";a="101907658"
Message-ID: <1498568066.13921.18.camel@linux.intel.com>
Subject: Re: [PATCH] firmware: remove request_firmware_into_buf()
From: Alan Cox <alan@linux.intel.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>,
        Daniel Wagner <wagi@monom.org>, David Woodhouse <dwmw2@infradead.org>,
        rafal@milecki.pl, Arend van Spriel <arend.vanspriel@broadcom.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>, yi1.li@linux.intel.com,
        atull@opensource.altera.com, Moritz Fischer <moritz.fischer@ettus.com>,
        pmladek@suse.com, Johannes Berg <johannes.berg@intel.com>,
        emmanuel.grumbach@intel.com, luciano.coelho@intel.com,
        Kalle Valo <kvalo@codeaurora.org>, luto@kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Kees Cook <keescook@chromium.org>,
        "AKASHI, Takahiro" <takahiro.akashi@linaro.org>,
        David Howells <dhowells@redhat.com>, pjones@redhat.com,
        Hans de Goede <hdegoede@redhat.com>, tytso@mit.edu,
        lkml <linux-kernel@vger.kernel.org>
Date: Tue, 27 Jun 2017 13:54:26 +0100
In-Reply-To: <CAOCOHw4WYM66itYRmu35_AP9ZMoTvmXMqRmS5LfAcBNAGdZaow@mail.gmail.com>
References: <20170623160321.GA19720@kroah.com>
         <CAOCOHw4WYM66itYRmu35_AP9ZMoTvmXMqRmS5LfAcBNAGdZaow@mail.gmail.com>
Organization: Intel Corporation
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 982
Lines: 25

On Mon, 2017-06-26 at 13:22 -0700, Bjorn Andersson wrote:
> On Fri, Jun 23, 2017 at 9:03 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > 
> > As Luis pointed out, there are no in-kernel users of
> > request_firmware_into_buf(), so remove it, and the now unused
> > internal
> > flag, which simplifies the logic around buffer handling a bit.
> > 
> 
> This API was implemented to reduce the memory pressure during
> firmware
> load in the Qualcomm remoteprocs, but it wasn't available when I
> upstreamed that code and I apparently forgot to send out the patch
> moving us over to use this API...
> 
> Especially when loading the Qualcomm modem we have a couple of files
> that we request_firmware() that are 10-15MB in size, so this
> functionality is definitely wanted.

It may also at some point be very useful for FPGA partial reprogramming
- the FPGA bitstreams are *not* small and most FPGAs you don't need all
of it in kernel memory at the same moment.

Alan