Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753210AbdF0Nbl (ORCPT <rfc822;w@1wt.eu>);
        Tue, 27 Jun 2017 09:31:41 -0400
Received: from mail-lf0-f66.google.com ([209.85.215.66]:33057 "EHLO
        mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752492AbdF0Nbb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 27 Jun 2017 09:31:31 -0400
Date: Tue, 27 Jun 2017 16:31:11 +0300
From: Roman Storozhenko <romeusmeister@gmail.com>
To: kvm@vger.kernel.org
Cc: joe@perches.com, christoffer.dall@linaro.org, marc.zyngier@arm.com,
        pbonzini@redhat.com, rkrcmar@redhat.com,
        linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: Replaces 'unsigned' with 'unsigned int' in the
 codebase
Message-ID: <20170627133111.GB21666@home>
Reply-To: "'Roman Storozhenko" <romeusmeister@gmail.com>, '@home
References: <20170627095401.GA19864@home>
 <9b50ee4b-d27a-8872-0cd3-cad8f5f0e0f8@redhat.com>
 <20170627120626.GA21666@home>
 <1498566090.24295.59.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1498566090.24295.59.camel@perches.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1580
Lines: 38

On Tue, Jun 27, 2017 at 05:21:30AM -0700, Joe Perches wrote:
> On Tue, 2017-06-27 at 15:06 +0300, Roman Storozhenko wrote:
> > On Tue, Jun 27, 2017 at 12:01:25PM +0200, Paolo Bonzini wrote:
> > > On 27/06/2017 11:54, Roman Storozhenko wrote:
> > > > Signed-off-by: Roman Storozhenko <romeusmeister@gmail.com>
> > > > ---
> > > >  virt/kvm/arm/arm.c        |  2 +-
> > > >  virt/kvm/coalesced_mmio.c |  2 +-
> > > >  virt/kvm/eventfd.c        | 10 ++++++----
> > > >  virt/kvm/irqchip.c        |  7 ++++---
> > > >  virt/kvm/kvm_main.c       | 16 ++++++++--------
> > > >  5 files changed, 20 insertions(+), 17 deletions(-)
> > > 
> > > This change is pointless.  Contributors to KVM should know what
> > > "unsigned" means.
> > 
> > Paolo, thanks that you mentioned this. But I have a question - is this just
> > useless or this is an error?
> 
> (Not Paulo and my 2c) Neither really.
> 
> > I saw many places in the codebase where 'unsigned int' is used. That why I
> > decided to make the codebase more standartized from the style point of
> > view.
> 
> In virt/kvm, there are 16 lines with unsigned, 160 with unsigned int
> 
> <shrug>, Both statements are correct, yes, it's kinda pointless,
> and, yes, it does standardize the declarations.
> 
> It's entirely up the the maintainers (Paulo and Radim) to apply
> or reject this style-only trivial patch.  The compiler doesn't care.
> 

Joe, thank you for your detailed answer.
Anyway I hope that this patch will be accepted despite it is useless
from the compiler's point of view. I think that the codebase style
matters too.