Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753282AbdF0PZM (ORCPT ); Tue, 27 Jun 2017 11:25:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45776 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752128AbdF0PTI (ORCPT ); Tue, 27 Jun 2017 11:19:08 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7A576104D5 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=bcodding@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7A576104D5 From: Benjamin Coddington To: Oleg Drokin , Andreas Dilger , James Simmons , Greg Kroah-Hartman , Eric Van Hensbergen , Ron Minnich , Latchesar Ionkov , "Yan, Zheng" , Sage Weil , Ilya Dryomov , Steve French , Christine Caulfield , David Teigland , Miklos Szeredi , Alexander Viro , Jeff Layton , "J. Bruce Fields" , Vitaly Fertman , "John L. Hammond" , Andriy Skulysh , Benjamin Coddington , Emoly Liu Cc: lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, cluster-devel@redhat.com, linux-fsdevel@vger.kernel.org Subject: [PATCH 0/3 v6] Fixups for l_pid Date: Tue, 27 Jun 2017 11:18:06 -0400 Message-Id: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 27 Jun 2017 15:18:57 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2132 Lines: 46 LTP fcntl tests (fcntl11 fcntl14 fcntl17 fcntl19 fcntl20 fcntl21) have been failing for NFSv4 mounts due to an unexpected l_pid. What follows are some fixups: v2: - Rebase onto linux-next - Revert back to using the stack in locks_mandatory_area(), and fixup patch description for 1/3 v3: - The lkp-robot found some serious per_thread_ops performance regressions for v1 and v2, so this version changes things around to not acquire a reference to struct pid in fl_nspid for every lock. Instead, it drops fl_nspid altogether, and defers the lookup of the namespace-translated pid until it actually needed. v4: - Instead of looking up the virtual pid by way of referencing the struct task of the that pid, instead use find_pid_ns() and pid_nr_ns(), which avoids a the problem where we race to get a reference to the struct task while it may be freed. v5: - Squash previous 2/3 and 3/3 to avoid regression where F_GETLK would return the init_ns pid instead of a translated pid. v6: - State clearly how the differing cases of l_pid translation should be handled, specifically regarding remote locks on remote files: that fl_pid ought to be returned from the filesystem as <= 0 to indicate that it makes no sense to translate this l_pid. - Follow up with a patch to have filesystems negate fl_pid for remote locks on remote files. Benjamin Coddington (3): fs/locks: Use allocation rather than the stack in fcntl_getlk() fs/locks: Remove fl_nspid and use fs-specific l_pid for remote locks staging/lustre, 9p, ceph, cifs, dlm: negate remote pids for F_GETLK drivers/staging/lustre/lustre/ldlm/ldlm_flock.c | 2 +- fs/9p/vfs_file.c | 2 +- fs/ceph/locks.c | 2 +- fs/cifs/cifssmb.c | 2 +- fs/dlm/plock.c | 2 +- fs/fuse/file.c | 6 +- fs/locks.c | 108 ++++++++++++++---------- include/linux/fs.h | 2 +- 8 files changed, 72 insertions(+), 54 deletions(-) -- 2.9.3