Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751567AbdF0P1V (ORCPT ); Tue, 27 Jun 2017 11:27:21 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:36952 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753157AbdF0P1C (ORCPT ); Tue, 27 Jun 2017 11:27:02 -0400 From: Olivier MOYSAN To: Rob Herring CC: "lgirdwood@gmail.com" , "broonie@kernel.org" , "perex@perex.cz" , "tiwai@suse.com" , "mcoquelin.stm32@gmail.com" , Alexandre TORGUE , "alsa-devel@alsa-project.org" , "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kernel@stlinux.com" , "linux-kernel@vger.kernel.org" , Arnaud POULIQUEN , Benjamin GAIGNARD Subject: Re: [PATCH 1/2] dt-bindings: Document the STM32 SPDIFRX interface Thread-Topic: [PATCH 1/2] dt-bindings: Document the STM32 SPDIFRX interface Thread-Index: AQHS7FI/+z3sOXZ7TES9ouOBg7LzFaI4uGKA Date: Tue, 27 Jun 2017 15:23:08 +0000 Message-ID: References: <1497621452-615-1-git-send-email-olivier.moysan@st.com> <1497621452-615-2-git-send-email-olivier.moysan@st.com> <20170623185514.nc3jqq6ikvwwv6sn@rob-hp-laptop> In-Reply-To: <20170623185514.nc3jqq6ikvwwv6sn@rob-hp-laptop> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.48] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-27_09:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v5RFRjLD006371 Content-Length: 2529 Lines: 75 Hello Rob, On 06/23/2017 08:55 PM, Rob Herring wrote: > On Fri, Jun 16, 2017 at 03:57:31PM +0200, olivier moysan wrote: >> This adds documentation of device tree bindings for the >> STM32 SPDIFRX interface. >> >> Signed-off-by: olivier moysan >> --- >> .../devicetree/bindings/sound/st,stm32-spdifrx.txt | 56 ++++++++++++++++++++++ >> 1 file changed, 56 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/st,stm32-spdifrx.txt >> >> diff --git a/Documentation/devicetree/bindings/sound/st,stm32-spdifrx.txt b/Documentation/devicetree/bindings/sound/st,stm32-spdifrx.txt >> new file mode 100644 >> index 0000000..33826f2 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/st,stm32-spdifrx.txt >> @@ -0,0 +1,56 @@ >> +STMicroelectronics STM32 S/PDIF receiver (SPDIFRX). >> + >> +The SPDIFRX peripheral, is designed to receive an S/PDIF flow compliant with >> +IEC-60958 and IEC-61937. >> + >> +Required properties: >> + - compatible: should be "st,stm32h7-spdifrx" >> + - reg: cpu DAI IP base address and size >> + - clocks: must contain an entry for kclk (used as S/PDIF signal reference) >> + - clock-names: must contain "kclk" >> + - interrupts: cpu DAI interrupt line >> + - dmas: DMA specifiers for audio data DMA and iec control flow DMA >> + See STM32 DMA bindings, Documentation/devicetree/bindings/dma/stm32-dma.txt >> + - dma-names: two dmas have to be defined, "rx" and "rx-ctrl" >> + >> +Optional properties: >> + - resets: Reference to a reset controller asserting the SPDIFRX >> + >> +The device node should contain one 'port' child node with one child 'endpoint' >> +node, according to the bindings defined in Documentation/devicetree/bindings/ >> +graph.txt. >> + >> +Example: >> +spdifrx: spdifrx@40004000 { >> + compatible = "st,stm32h7-spdifrx"; >> + reg = <0x40004000 0x400>; >> + clocks = <&rcc SPDIFRX_CK>; >> + clock-names = "kclk"; >> + interrupts = <97>; >> + dmas = <&dmamux1 2 93 0x400 0x0>, >> + <&dmamux1 3 94 0x400 0x0>; >> + dma-names = "rx", "rx-ctrl"; >> + pinctrl-0 = <&spdifrx_pins>; >> + pinctrl-names = "default"; >> + >> + spdifrx_port: port { >> + cpu_endpoint: endpoint { >> + remote-endpoint = <&codec_endpoint>; >> + }; >> + }; >> +}; >> + >> +spdif_in: spdif-in { >> + compatible = "linux,spdif-dir"; > > What is this? It should go. > > Rob > This is the ASoC spdif stub codec. This is relevant in DT when spdif interface is wired to a connector. I will remove it from bindings. BRs olivier