Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752600AbdF0Pds (ORCPT ); Tue, 27 Jun 2017 11:33:48 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:45634 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752396AbdF0Pc5 (ORCPT ); Tue, 27 Jun 2017 11:32:57 -0400 Subject: Re: selftests/capabilities: test FAIL on linux mainline and linux-next and PASS on linux-4.4.70+ To: Naresh Kamboju , luto@kernel.org, keescook@chromium.org Cc: linux-kselftest@vger.kernel.org, "linux-kernel@vger.kernel.org" , Shuah Khan , Shuah Khan References: From: Shuah Khan Message-ID: <72ee8828-c708-8889-b2c8-95fe3bb28117@osg.samsung.com> Date: Tue, 27 Jun 2017 09:32:45 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4281 Lines: 130 Hi Naresh, On 06/27/2017 02:40 AM, Naresh Kamboju wrote: > selftest capabilities test failed on linux mainline and linux-next and > PASS on linux-4.4.70+ > Tested on HiKey ARM64 Development board. > > A bug reported in Linaro bug tracking system, > LKFT: Capabilities test_execve fail Wrong effective state AT_SECURE is not set > https://bugs.linaro.org/show_bug.cgi?id=2947 > > Please guide me to debug the reason for failure. > Kernel config link, > https://pastebin.com/P1uYmdMG > > Linux version 4.12.0-rc7-00004-gda8b14e (buildslave@x86-64-08) (gcc > version 6.2.1 20161016 (Linaro GCC 6.2-2016.11) ) #1 SMP PREEMPT Mon > Jun 26 20:04:35 UTC 2017 > > Linux version 4.12.0-rc7-next-20170627 (buildslave@x86-64-07) (gcc > version 6.2.1 20161016 (Linaro GCC 6.2-2016.11)) #1 SMP PREEMPT Tue > Jun 27 06:33:39 UTC 2017 > > LAVA job id: > https://lkft.validation.linaro.org/scheduler/job/4397#L1412 > > Running tests in capabilities > ======================================== > [OK] Capabilities after execve were correct > [OK] Capabilities after execve were correct > [OK] Capabilities after execve were correct > [OK] Capabilities after execve were correct > [FAIL] Wrong effective state (AT_SECURE is not set) > [OK] Capabilities after execve were correct > [FAIL] Wrong ambient state (AT_SECURE is not set) > [FAIL] Wrong ambient state (AT_SECURE is not set) > [RUN] +++ Tests with uid == 0 +++ > [NOTE] Using global UIDs for tests > [RUN] Root => ep > [OK] Child succeeded > [OK] Check cap_ambient manipulation rules > [OK] PR_CAP_AMBIENT_RAISE failed on non-inheritable cap > [OK] PR_CAP_AMBIENT_RAISE failed on non-permitted cap > [OK] PR_CAP_AMBIENT_RAISE worked > [OK] Basic manipulation appears to work > [RUN] Root +i => eip > [OK] Child succeeded > [RUN] UID 0 +ia => eipa > [OK] Child succeeded > [RUN] Root +ia, suidroot => eipa > [OK] Child succeeded Okay the following appears to be the first difference between the runs on the mainline and 4.4.74 When udi != 0 case, these tests fail. Could it be that there are security related changes to this area and the tests need updates? Kees/Andy: Do you have any insight thanks, -- Shuah ------------------------------------ > [RUN] Root +ia, suidnonroot => ip > [FAIL] Child failed > [RUN] Root +ia, sgidroot => eipa > [OK] Child succeeded > [FAIL] Child failed > [RUN] Root +ia, sgidnonroot => eip > [FAIL] Child failed ------------------------------------- > [OK] Capabilities after execve were correct > [OK] Capabilities after execve were correct > [OK] Capabilities after execve were correct > [FAIL] Wrong effective state (AT_SECURE is not set) > [FAIL] Child failed > [FAIL] Child failed > selftests: test_execve [FAIL] > > capabilities test PASS on Linux-4.4.70+. > > Running tests in capabilities > ======================================== > case: step_after_suspend_test > definition: 1_kselftest > result: skip > [OK] Capabilities after execve were correct > [OK] Capabilities after execve were correct > [OK] Capabilities after execve were correct > [OK] Capabilities after execve were correct > [OK] Capabilities after execve were correct > [OK] Capabilities after execve were correct > [OK] Capabilities after execve were correct > [OK] Capabilities after execve were correct > [RUN] +++ Tests with uid == 0 +++ > [NOTE] Using global UIDs for tests > [RUN] Root => ep > [OK] Child succeeded > [OK] Check cap_ambient manipulation rules > [OK] PR_CAP_AMBIENT_RAISE failed on non-inheritable cap > [OK] PR_CAP_AMBIENT_RAISE failed on non-permitted cap > [OK] PR_CAP_AMBIENT_RAISE worked > [OK] Basic manipulation appears to work > [RUN] Root +i => eip > [OK] Child succeeded > [RUN] UID 0 +ia => eipa > [OK] Child succeeded > [RUN] Root +ia, suidroot => eipa > [OK] Child succeeded > [RUN] Root +ia, suidnonroot => ip > [OK] Child succeeded > [RUN] Root +ia, sgidroot => eipa > [OK] Child succeeded > [OK] Child succeeded > [RUN] Root +ia, sgidnonroot => eip > [OK] Child succeeded > [OK] Capabilities after execve were correct > [OK] Capabilities after execve were correct > [OK] Capabilities after execve were correct > [OK] Capabilities after execve were correct > [OK] Child succeeded > [OK] Child succeeded > selftests: test_execve [PASS] > > Thanks and best regards, > Naresh Kamboju >