Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752787AbdF0Pgn (ORCPT ); Tue, 27 Jun 2017 11:36:43 -0400 Received: from mail-pg0-f45.google.com ([74.125.83.45]:34481 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751508AbdF0PgR (ORCPT ); Tue, 27 Jun 2017 11:36:17 -0400 Date: Tue, 27 Jun 2017 08:36:12 -0700 From: Benson Leung To: Thierry Escande Cc: Lee Jones , Benson Leung , linux-kernel@vger.kernel.org, enric.balletbo@collabora.com Subject: Re: [PATCH v2 2/3] cros_ec: Fix deadlock when EC is not responsive at probe Message-ID: <20170627153612.GB39605@decatoncale.mtv.corp.google.com> References: <1487102282-12259-1-git-send-email-thierry.escande@collabora.com> <1487102282-12259-3-git-send-email-thierry.escande@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kXdP64Ggrk/fb43R" Content-Disposition: inline In-Reply-To: <1487102282-12259-3-git-send-email-thierry.escande@collabora.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1913 Lines: 55 --kXdP64Ggrk/fb43R Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Thierry, On Tue, Feb 14, 2017 at 08:58:01PM +0100, Thierry Escande wrote: > From: Gwendal Grignou >=20 > When the EC is not responsive at probe, we try to get basic information > (protocol to use) later on through cros_xfer_cmd() call. > This patch makes sure there is no deadlock when re-probing the EC by > replacing call to cros_xfer_cmd() with send_command() in the function > cros_ec_get_host_command_version_mask(). Also, this patch adds the > function header indicating it must be called protected. >=20 > Signed-off-by: Gwendal Grignou > Signed-off-by: Thierry Escande Applied. Thanks again! --=20 Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org --kXdP64Ggrk/fb43R Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJZUntsAAoJEB8J9XsKL+ZYIwMP/RV0WogM4KDjefLQmv3EIQSV j5oeQHpm99j1wHt1JAuw7HksujfWvtgB34oJGKYwf1M2I++dkiEoEMtEDpkEllBo SPMZB/ffyUEFPWLcazTALD+OIkuXLcXEhEz3Sx+VraAIkmxogPKFbmQFN7c/lt67 3qf6PjMrTomeknImK9B6KHGEysnvpaA3pKc3mAKXFMr4qwi7jzn9jpUwo2v1Szo3 4fgBgkEulA/DCyGw47kJM+qLUP4b05J0353NHwrYtHtuWRv3xT1kXEZw7pAnQe/A J9hzvUMbGq37OO1fjyI52okw+t5WI899D42K5/6NvvcLmxiL7rmkNkPBYcoPttGt FGtIfeDf4D1xu+lqF0kHiW0/znIv4nO5IetLh3u0JcSvBdY/VYfjBvbPumdHzV3x Y1bk1tEdMJeAtvkx3u9kVhSyrAM6qUKBFyyjoGlzWus7Gvxo/I84SaIgQftKh0cE dwQO4IjyWBPf6sa2W4KnSsjLvdxgKE9fuPxESHZBgKp/8mNQONB4v9q/ZH4Jf21v heESbZOVNCl5I2KZ2GO2zRU+QskNn3VmSjYkQ5+4HG/g9vQ/gFPj60rffWJskYFi zWQBoakhQwcIAf8dLPFA0pnipUZH4Xwfy0fQlvSPrTTCntPGAj7VyePxA9ocP5ci Kubi2kROz+I5XdK/B6vC =9DmL -----END PGP SIGNATURE----- --kXdP64Ggrk/fb43R--