Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751575AbdF0Pyf (ORCPT ); Tue, 27 Jun 2017 11:54:35 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52356 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751499AbdF0Py2 (ORCPT ); Tue, 27 Jun 2017 11:54:28 -0400 Date: Tue, 27 Jun 2017 17:54:27 +0200 From: Greg KH To: Arvind Yadav Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] usb: host: ohci-pxa27x: Handle return value of clk_prepare_enable Message-ID: <20170627155427.GA13306@kroah.com> References: <69584177f6011df02d45c74923e9e74e560cbb22.1498540611.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <69584177f6011df02d45c74923e9e74e560cbb22.1498540611.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 339 Lines: 12 On Tue, Jun 27, 2017 at 10:47:28AM +0530, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > drivers/usb/host/ohci-pxa27x.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > No changelog here? Please fix.