Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753140AbdF0QMI (ORCPT ); Tue, 27 Jun 2017 12:12:08 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:56662 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751579AbdF0QL7 (ORCPT ); Tue, 27 Jun 2017 12:11:59 -0400 Date: Tue, 27 Jun 2017 18:11:26 +0200 From: Greg KH To: Shuah Khan Cc: paul.elder@pitt.edu, panand@redhat.com, will.deacon@arm.com, labath@google.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests: breakpoints: convert breakpoint_test_arm64 test to TAP13 Message-ID: <20170627161126.GA10534@kroah.com> References: <20170627160447.11345-1-shuahkh@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170627160447.11345-1-shuahkh@osg.samsung.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1500 Lines: 39 On Tue, Jun 27, 2017 at 10:04:47AM -0600, Shuah Khan wrote: > Convert breakpoint_test_arm64 output to TAP13 format. > > Signed-off-by: Shuah Khan > --- > .../selftests/breakpoints/breakpoint_test_arm64.c | 114 ++++++++++++++------- > 1 file changed, 79 insertions(+), 35 deletions(-) > > diff --git a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c > index fa6d57af5217..d13bd0dea13e 100644 > --- a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c > +++ b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c > @@ -41,20 +41,27 @@ static volatile uint8_t var[96] __attribute__((__aligned__(32))); > static void child(int size, int wr) > { > volatile uint8_t *addr = &var[32 + wr]; > + char msg_buf[512]; > > if (ptrace(PTRACE_TRACEME, 0, NULL, NULL) != 0) { > - perror("ptrace(PTRACE_TRACEME) failed"); > - _exit(1); > + snprintf(msg_buf, sizeof(msg_buf), > + "ptrace(PTRACE_TRACEME) failed: %s\n", > + strerror(errno)); > + ksft_exit_fail_msg(msg_buf); No objection to this patch, but perhaps the "msg" functions could either be variable arg macros, or just a printk() like function that can take the string and anything you want to send to it. So this could be: ksft_exit_fail_msg("ptrace(PTRACE_TRACEME) failed: %s\n", strerror(errno)); Anyway, just a thought, might make conversions a lot easier, no need for intermediate buffers. thanks, greg k-h