Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752971AbdF0QWR (ORCPT ); Tue, 27 Jun 2017 12:22:17 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:36202 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752759AbdF0QV5 (ORCPT ); Tue, 27 Jun 2017 12:21:57 -0400 Subject: Re: [PATCH 3/3] mtd: spi-nor: Altera Quadspi Flash Controller v2 Platform driver To: matthew.gerlach@linux.intel.com References: <1498493619-4633-1-git-send-email-matthew.gerlach@linux.intel.com> <1498493619-4633-4-git-send-email-matthew.gerlach@linux.intel.com> <2ac33989-5665-33e0-c6f0-6791c8e46b0d@gmail.com> Cc: vndao@altera.com, dwmw2@infradead.org, computersforpeace@gmail.com, boris.brezillon@free-electrons.com, richard@nod.at, cyrille.pitchen@wedev4u.fr, robh+dt@kernel.org, mark.rutland@arm.com, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, davem@davemloft.net, mchehab@kernel.org From: Marek Vasut Message-ID: <5f0e2ddd-d329-cb3d-01bc-c101247281a7@gmail.com> Date: Tue, 27 Jun 2017 18:21:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1427 Lines: 43 On 06/27/2017 05:15 PM, matthew.gerlach@linux.intel.com wrote: > > > On Tue, 27 Jun 2017, Marek Vasut wrote: > >> On 06/26/2017 06:13 PM, matthew.gerlach@linux.intel.com wrote: >>> From: Matthew Gerlach >> >> Just wrap it into the Altera QSPI driver , no need for separate platform >> driver IMO. > > Hi Marek, > > I answered this question when you asked why the header file was > necessary, but I think further discussion could be helpful, since this > problem is becoming more prevelent. The Altera Quadspi component is a > soft IP in a > FPGA, and the processor using the component may or may not have device > tree support compiled into the Linux kernel. Since device tree support > may or may not be available, the device tree specific code must be > separated > from the core driver code. I see, that's fine, although there is no PCIe or other support in this submission. Is that planned ? > One can certainly make the case, that device tree support could/should > be available everywhere, but the current reality is most x86 Linux > kernel configurations do not include device tree support. > > For the record, I believe device trees, and more specifically device > tree overlays, are the best way for Linux to use FPGAs, but I have to > deal with the current realities. > > Thanks again for all the great feedback. > > Matthew Gerlach [...] -- Best regards, Marek Vasut