Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752729AbdF0Q3Z (ORCPT ); Tue, 27 Jun 2017 12:29:25 -0400 Received: from mail-pg0-f46.google.com ([74.125.83.46]:36766 "EHLO mail-pg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751492AbdF0Q3T (ORCPT ); Tue, 27 Jun 2017 12:29:19 -0400 Date: Tue, 27 Jun 2017 09:29:14 -0700 From: Benson Leung To: Arnd Bergmann Cc: Olof Johansson , Enric Balletbo i Serra , Guenter Roeck , Lee Jones , Jonathan Cameron , Benson Leung , Eric Caruso , Gwendal Grignou , Vincent Palatin , Jeffery Yu , Logan Gunthorpe , linux-kernel@vger.kernel.org Subject: Re: [PATCH] platform/chrome: cros_ec_lightbar - hide unused PM functions Message-ID: <20170627162914.GD39605@decatoncale.mtv.corp.google.com> References: <20170627153705.1378256-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="76DTJ5CE0DCVQemd" Content-Disposition: inline In-Reply-To: <20170627153705.1378256-1-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1957 Lines: 57 --76DTJ5CE0DCVQemd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Arnd, On Tue, Jun 27, 2017 at 05:36:36PM +0200, Arnd Bergmann wrote: > The only reference to the new functions is inside of an #ifdef, > which now causes a harmless warning when CONFIG_PM_SLEEP is not set: >=20 > chrome/cros_ec_dev.c:478:12: error: 'ec_device_resume' defined but not us= ed [-Werror=3Dunused-function] > chrome/cros_ec_dev.c:469:12: error: 'ec_device_suspend' defined but not u= sed [-Werror=3Dunused-function] >=20 > This marks the two functions as __maybe_unused so they can get > silently dropped by the compiler. >=20 > Fixes: 405c84308c43 ("platform/chrome: cros_ec_lightbar - Control of susp= end/resume lightbar sequence") > Signed-off-by: Arnd Bergmann Good catch. Applied. Thanks! --=20 Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org --76DTJ5CE0DCVQemd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJZUofaAAoJEB8J9XsKL+ZYN2gQAJFhl78hbn+eFzoOhplCOPO0 aLEnXEFXCEoQQKyhuq9q72tn4euvBOMbb7dO9AWWPcdaw69ZQOLfz80euCLiiWQq Fr9fBfY3CJUjDy5mQiI8eoN+34yVsmxtqQI4irbXb/yb/UuFJ8WnmpIeL1sjMA2n TKfdQXDXyuB+aOz83P4OGpcESvUId2tagORb5x5vzM+xA9jj8eIj5L0fHfEF26K2 pw/hTob2uEtl9WfEABomtbdrJMf0b0br351J3DfXpztstmpe+QQUmx1iCS2mWG1P kq/sCy7SVFp/Qy5TjCEd7aYfBIiIcJiZE/A2blu1pUwbSXykgyHBGU/hPrRnsrVR ee4y45a43mclGCbxokdmA4u/usoAcvPc/MkDaDA+fr2wGqQD60uS/8JAikSKZW97 jJfYFXG5sC7721pdj+BwEERbkYLc+o+x13JNxGP2b1pm8qGvHPZtHgQP+1Ens6u6 nV0WfzOeWojuFdpBXyE4M93J9yJ5kGR5+b4Wd+n0lljJdBCaKvn8y5GROgRCzp80 ADcsg8aseGGl8O29YuQBDR4d6Sf/93MfOXlmzydsytUKy44ydn2P6CeqVcoe/uIp hpBD5epO07qxSd+RvVW0a3dKoslY6leAEJuRcfHGyWAsstEY+Pdo+zztKTuqFx2A GN8IQd4XD7Hwdvyu21bM =lHrF -----END PGP SIGNATURE----- --76DTJ5CE0DCVQemd--