Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752249AbdF0QiO (ORCPT ); Tue, 27 Jun 2017 12:38:14 -0400 Received: from mail-he1eur01on0080.outbound.protection.outlook.com ([104.47.0.80]:62528 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751541AbdF0QiH (ORCPT ); Tue, 27 Jun 2017 12:38:07 -0400 From: Leo Li To: Scott Wood , Karim Eshapa CC: Roy Pledge , "linux-kernel@vger.kernel.org" , Claudiu Manoil , "colin.king@canonical.com" , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [v3] drivers:soc:fsl:qbman:qman.c: Sleep instead of stuck hacking jiffies. Thread-Topic: [v3] drivers:soc:fsl:qbman:qman.c: Sleep instead of stuck hacking jiffies. Thread-Index: AQHS7V1NUVQdZdsClEi2qPyQPpGOOaI46t7g Date: Tue, 27 Jun 2017 16:38:00 +0000 Message-ID: References: <1493963118-11064-1-git-send-email-karim.eshapa@gmail.com> <20170625024638.t6awgp7omzq5dcnk@home.buserror.net> In-Reply-To: <20170625024638.t6awgp7omzq5dcnk@home.buserror.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: buserror.net; dkim=none (message not signed) header.d=none;buserror.net; dmarc=none action=none header.from=nxp.com; x-originating-ip: [192.88.168.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR0401MB2573;7:QUtXY1bzSnkziP/nEc4oxJS+CR1Bm0gqUgsMGbtRMsSWhjuR2iCHJzF6lCb1ah/qqTRtljieitHVEMWYpVWuK5xOWTYFZR7L1TbBFrSfTQjcy8oaKtnteeDIx1GnnP3hTcdtpdo9BwLGz2xc9875EjSqCQLfS9X+4rtCxvnuWsC8ltcPgDZy2ahbS/a1CQHEqIKEF3da7UAg9hxHs6IckNx2Wxr9/Ym1q3FRsS7jgFfXaFwqkWrshFoeTYtnd/CtTbSVDqu1bZBGW6KbYYXVrrkzmr/B3FXocFsctXrgG5E2fhgKDmSSOaO7/XfCz+juU5OJXeRUiQkaSzCrRCjY4yPRFTrcepoWfx6gxIc2qJ6Ph2VgmJfVCEOgqUksqg8hv4B1Rv13F5en9z2Bs/ZtmHUEqKdgPc3+SbePiVBEGkPF//kG9pQEVRT8Kds1KxQlastl0iIA+KS+lxxSqlah3oXUGH9ZVq2G+s58S9RQbpqKYY1ypGfhYuCaZiVJyZz+As6Uo+7WQrUg60pGOcGsOFoZcwUkcgVWZAIipDf/JTyYAtWvG1qQheAPBT0fCFGbKIv/JqVKKRFNs39DT2ufZI6h+8Dv0XsTovmubPAaqWvADB6FOvtqFGo/Z/a4r2JAlBxV5m1y924LarZoZiq+Wgv/dChT0iHNN3PCiGDgZIVRmdzF3m9PulQRerzUd99KsiwvepG71qBp5cc4dyOLUHbyNwpL23FeliVyEpCGrRY6wwl8n9PZLer0MW6jAtZCd4Pt2F5uIE9rr0n2j1r//79MQcX+Z79XxrRGTRhUZxE= x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(6009001)(39840400002)(39860400002)(39450400003)(39850400002)(39410400002)(39400400002)(377454003)(13464003)(24454002)(3846002)(102836003)(8936002)(2906002)(53546010)(6116002)(189998001)(39060400002)(14454004)(25786009)(38730400002)(6506006)(7736002)(66066001)(3660700001)(4326008)(86362001)(6436002)(3280700002)(53936002)(6246003)(5660300001)(7696004)(74316002)(229853002)(54906002)(76176999)(99286003)(5250100002)(55016002)(8676002)(305945005)(2950100002)(9686003)(33656002)(81156014)(54356999)(50986999)(81166006)(2900100001)(478600001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0401MB2573;H:AM4PR0401MB1699.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; x-ms-office365-filtering-correlation-id: 427d1e97-b848-4eef-6284-08d4bd7ae02a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(300000503095)(300135400095)(48565401081)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095);SRVR:VI1PR0401MB2573; x-ms-traffictypediagnostic: VI1PR0401MB2573: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(236129657087228)(9452136761055)(65623756079841)(185117386973197)(258649278758335)(167848164394848)(198206253151910); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(6055026)(6041248)(20161123564025)(20161123562025)(20161123558100)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:VI1PR0401MB2573;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:VI1PR0401MB2573; x-forefront-prvs: 0351D213B3 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jun 2017 16:38:00.9991 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2573 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5RGcKLZ017088 Content-Length: 1230 Lines: 32 > -----Original Message----- > From: Scott Wood [mailto:oss@buserror.net] > Sent: Saturday, June 24, 2017 9:47 PM > To: Karim Eshapa > Cc: Roy Pledge ; linux-kernel@vger.kernel.org; > Claudiu Manoil ; colin.king@canonical.com; > linuxppc-dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org; Leo Li > > Subject: Re: [v3] drivers:soc:fsl:qbman:qman.c: Sleep instead of stuck > hacking jiffies. > > On Fri, May 05, 2017 at 07:45:18AM +0200, Karim Eshapa wrote: > > Use msleep() instead of stucking with > > long delay will be more efficient. > > > > Signed-off-by: Karim Eshapa > > --- > > drivers/soc/fsl/qbman/qman.c | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > Acked-by: Scott Wood > > (though the subject line should be "soc/qman: ...") > > Leo, are you going to send this patch (and other qman patches) via arm-soc? Yes. I can take it through the pull request for soc/fsl via arm-soc. As mentioned in the feedback from David in another email, probably we should update the comment and commit message to mention how 10000 cycles becomes 1ms. Regards, Leo