Subject: Re: [PATCH 6/6] Documentation/devicetree: Add FSI-attached I2C master
 dt bindings
To: Jeremy Kerr <jk@ozlabs.org>, linux-kernel@vger.kernel.org
Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
        wsa@the-dreams.de, robh+dt@kernel.org, gregkh@linuxfoundation.org,
        joel@jms.id.au, andrew@aj.id.au,
        "Edward A. James" <eajames@us.ibm.com>
References: <1498505375-1454-1-git-send-email-eajames@linux.vnet.ibm.com>
 <1498505375-1454-7-git-send-email-eajames@linux.vnet.ibm.com>
 <ec4a5fec-fea0-09a7-8559-99d8eb071093@ozlabs.org>
From: Eddie James <eajames@linux.vnet.ibm.com>
Date: Tue, 27 Jun 2017 12:28:14 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.0
MIME-Version: 1.0
In-Reply-To: <ec4a5fec-fea0-09a7-8559-99d8eb071093@ozlabs.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Message-Id: <901bb9e4-a7b1-ce24-c68b-d96b61e1b274@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1328
Lines: 50


On 06/26/2017 08:06 PM, Jeremy Kerr wrote:
> Hi Eddie,
>
>> +Required properties:
>> + - compatible = "ibm,i2cm-fsi";
>> + - reg = < address size >;		: The FSI CFAM address and address space
>> +					  size.
>> + - #address-cells = <1>;		: Number of address cells in child nodes
>> + - #size-cells = <0>;			: Number of size cells in child nodes.
>> + - child nodes				: Nodes to describe ports off the I2C
>> +					  master.
>> +
>> +Child node required properties:
>> + - reg = < port number >		: The port number on the I2C master.
>> +
>> +Examples:
>> +
>> +    i2cm@1800 {
>> +        compatible = "ibm,i2cm-fsi";
>> +        reg = < 0x1800 0x400 >;
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>> +        port@0 {
>> +            reg = <0>;
>> +        };
>> +
>> +        port@1 {
>> +            reg = <1>;
>> +        };
>> +    };
> Those child nodes represent the downstream i2c buses, and so also
> contain the i2c slave devices, right? If so, you may want to document
> that, and/or add a simple device to that example (say, an EEPROM).

Yes, good point, but the driver currently wouldn't do anything with that 
device information. It doesn't keep a list of populated devices on the 
bus or anything. Still worth adding them to the device tree?

Thanks,
Eddie

>
> Cheers,
>
>
> Jeremy
>