Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753446AbdF0T2v (ORCPT ); Tue, 27 Jun 2017 15:28:51 -0400 Received: from mail-ua0-f195.google.com ([209.85.217.195]:33443 "EHLO mail-ua0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752646AbdF0T2o (ORCPT ); Tue, 27 Jun 2017 15:28:44 -0400 MIME-Version: 1.0 In-Reply-To: <20170620084958.7fxdn57p3o6eexbj@phenom.ffwll.local> References: <20170531.110833.1362264472730468352.davem@davemloft.net> <20170531155043.3596-1-jani.nikula@intel.com> <20170531155043.3596-2-jani.nikula@intel.com> <20170602.141426.713378366601051907.davem@davemloft.net> <1496781986.86439.3.camel@intel.com> <309B89C4C689E141A5FF6A0C5FB2118B8C61D137@ORSMSX101.amr.corp.intel.com> <20170620084958.7fxdn57p3o6eexbj@phenom.ffwll.local> From: Dave Airlie Date: Wed, 28 Jun 2017 05:28:42 +1000 Message-ID: Subject: Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails To: "Brown, Aaron F" , "Kirsher, Jeffrey T" , David Miller , "Nikula, Jani" , "Ursulin, Tvrtko" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "jani.nikula@linux.intel.com" , "chris@chris-wilson.co.uk" , "Ertman, David M" , "intel-wired-lan@lists.osuosl.org" , "dri-devel@lists.freedesktop.org" , "netdev@vger.kernel.org" , "airlied@gmail.com" Cc: "daniel.vetter@ffwll.ch" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2425 Lines: 58 On 20 June 2017 at 18:49, Daniel Vetter wrote: > On Wed, Jun 07, 2017 at 01:07:33AM +0000, Brown, Aaron F wrote: >> > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On Behalf >> > Of Jeff Kirsher >> > Sent: Tuesday, June 6, 2017 1:46 PM >> > To: David Miller ; Nikula, Jani >> > >> > Cc: Ursulin, Tvrtko ; daniel.vetter@ffwll.ch; intel- >> > gfx@lists.freedesktop.org; linux-kernel@vger.kernel.org; >> > jani.nikula@linux.intel.com; chris@chris-wilson.co.uk; Ertman, David M >> > ; intel-wired-lan@lists.osuosl.org; dri- >> > devel@lists.freedesktop.org; netdev@vger.kernel.org; airlied@gmail.com >> > Subject: Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo >> > e1000e_pm_freeze if __e1000_shutdown fails >> > >> > On Fri, 2017-06-02 at 14:14 -0400, David Miller wrote: >> > > From: Jani Nikula >> > > Date: Wed, 31 May 2017 18:50:43 +0300 >> > > >> > > > From: Chris Wilson >> > > > >> > > > An error during suspend (e100e_pm_suspend), >> > > >> > > ... >> > > > lead to complete failure: >> > > >> > > ... >> > > > The unwind failures stems from commit 2800209994f8 ("e1000e: >> > > > Refactor PM >> > > > flows"), but it may be a later patch that introduced the non- >> > > > recoverable >> > > > behaviour. >> > > > >> > > > Fixes: 2800209994f8 ("e1000e: Refactor PM flows") >> > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99847 >> > > > Cc: Tvrtko Ursulin >> > > > Cc: Jeff Kirsher >> > > > Cc: Dave Ertman >> > > > Cc: Bruce Allan >> > > > Cc: intel-wired-lan@lists.osuosl.org >> > > > Cc: netdev@vger.kernel.org >> > > > Signed-off-by: Chris Wilson >> > > > [Jani: bikeshed repainted] >> > > > Signed-off-by: Jani Nikula >> > > >> > > Jeff, please make sure this gets submitted to me soon. >> > >> > Expect it later tonight, just finishing up testing. >> >> Tested-by: Aaron Brown > > Hm, I seem to be blind, but I can't find it anywhere in -rc6. Does someone > have the sha1 from Linus' git for this patch? Guys this is a pretty serious regression, just left blowing in the wind, is anyone responsible for e1000e? Dave.