From: "Kershner, David A" <David.Kershner@unisys.com>
To: Quytelda Kahja <quytelda@tamalin.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "Sell, Timothy C" <Timothy.Sell@unisys.com>,
        "Binder, David Anthony" <David.Binder@unisys.com>
CC: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] Staging: visorbus: Fix coding style warning from
 checkpatch.pl.
Thread-Topic: [PATCH] Staging: visorbus: Fix coding style warning from
 checkpatch.pl.
Thread-Index: AQHS7tSIa1HvCuLGqUyMz0kP5Oy6saI5K6fA
Date: Tue, 27 Jun 2017 20:37:47 +0000
Message-ID: <CY4PR07MB317673D4A04D8F98AB9DC8C1F0DC0@CY4PR07MB3176.namprd07.prod.outlook.com>
References: <20170626233130.5834-1-quytelda@tamalin.org>
In-Reply-To: <20170626233130.5834-1-quytelda@tamalin.org>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jun 2017 20:37:47.0496
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8d894c2b-238f-490b-8dd1-d93898c5bf83
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3126
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5RKcQ6h022362
Content-Length: 1682
Lines: 48

> -----Original Message-----
> From: Quytelda Kahja [mailto:quytelda@tamalin.org]
> Sent: Monday, June 26, 2017 7:32 PM
> To: Kershner, David A <David.Kershner@unisys.com>;
> gregkh@linuxfoundation.org; Sell, Timothy C <Timothy.Sell@unisys.com>;
> Binder, David Anthony <David.Binder@unisys.com>
> Cc: devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; Quytelda
> Kahja <quytelda@tamalin.org>
> Subject: [PATCH] Staging: visorbus: Fix coding style warning from
> checkpatch.pl.
> 
> Replace the literal function name "create_bus_instance" with the format
> specifier "%s" so it can be dynamically filled by the __func__ macro.
> 
> Signed-off-by: Quytelda Kahja <quytelda@tamalin.org>

I can't get this to apply to Greg's staging-next branch. It appears to be missing
at least patch: 

commit 9e78fd35d staging: unisys: visorbus: renamed functions like *_bus_instance 
			       to match driver namespace

Please update and send again. 

Thanks, 
David Kershner

> ---
>  drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
> b/drivers/staging/unisys/visorbus/visorbus_main.c
> index a692561c81c8..b6caa7a98692 100644
> --- a/drivers/staging/unisys/visorbus/visorbus_main.c
> +++ b/drivers/staging/unisys/visorbus/visorbus_main.c
> @@ -1032,7 +1032,7 @@ create_bus_instance(struct visor_device *dev)
>  err_debugfs_dir:
>  	debugfs_remove_recursive(dev->debugfs_dir);
>  	kfree(hdr_info);
> -	dev_err(&dev->device, "create_bus_instance failed: %d\n", err);
> +	dev_err(&dev->device, "%s failed: %d\n", __func__, err);
>  	return err;
>  }
> 
> --
> 2.13.2