Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753652AbdF0Ukp (ORCPT ); Tue, 27 Jun 2017 16:40:45 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53304 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753593AbdF0Ukg (ORCPT ); Tue, 27 Jun 2017 16:40:36 -0400 Date: Tue, 27 Jun 2017 13:40:33 -0700 From: Andrew Morton To: Rasmus Villemoes Cc: Vlastimil Babka , huang ying , mm-commits@vger.kernel.org, LKML , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-next@vger.kernel.org, Stephen Rothwell , mhocko@suse.cz, Mark Brown Subject: Re: mmotm 2017-06-23-15-03 uploaded Message-Id: <20170627134033.d6df2435117d52721d37a748@linux-foundation.org> In-Reply-To: References: <594d905d.geNp0UO7DULvNDPS%akpm@linux-foundation.org> <13ab3968-a7e4-add3-b050-438d462f7fc4@suse.cz> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1214 Lines: 34 On Tue, 27 Jun 2017 09:38:09 +0200 Rasmus Villemoes wrote: > >> > >> However, the patch in mmotm seems to be missing this crucial hunk that > >> Rasmus had in the patch he sent [1]: > >> > >> -__rmqueue_fallback(struct zone *zone, unsigned int order, int > >> start_migratetype) > >> +__rmqueue_fallback(struct zone *zone, int order, int start_migratetype) > >> > >> which makes this a signed vs signed comparison. > >> > >> What happened to it? Andrew? > > This is really odd. Checking, I see that it was also absent from the > 'this patch has been added to -mm' mail, but I admit I don't proofread > those to see they match what I sent. Oh well. Let me know if I need to > do anything. > oops, that was me manually fixing rejects - I missed a bit. --- a/mm/page_alloc.c~mm-page_allocc-eliminate-unsigned-confusion-in-__rmqueue_fallback-fix +++ a/mm/page_alloc.c @@ -2212,7 +2212,7 @@ static bool unreserve_highatomic_pageblo * condition simpler. */ static inline bool -__rmqueue_fallback(struct zone *zone, unsigned int order, int start_migratetype) +__rmqueue_fallback(struct zone *zone, int order, int start_migratetype) { struct free_area *area; int current_order; _