Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753867AbdF0Vkg (ORCPT ); Tue, 27 Jun 2017 17:40:36 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:60544 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753653AbdF0Vk3 (ORCPT ); Tue, 27 Jun 2017 17:40:29 -0400 Date: Tue, 27 Jun 2017 23:40:18 +0200 From: Ralf Baechle To: Karl Beldan Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Karl Beldan , stable@vger.kernel.org, Jonas Gorski Subject: Re: [RESEND PATCH] MIPS: head: Reorder instructions missing a delay slot Message-ID: <20170627214018.GD10090@linux-mips.org> References: <20170627192216.29364-1-karl.beldan+oss@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170627192216.29364-1-karl.beldan+oss@gmail.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 362 Lines: 13 On Tue, Jun 27, 2017 at 07:22:16PM +0000, Karl Beldan wrote: > In this sequence the 'move' is assumed in the delay slot of the 'beq', > but head.S is in reorder mode and the former gets pushed one 'nop' > farther by the assembler. > > The corrected behavior made booting with an UHI supplied dtb erratic. Excellent catch, patch applied! Thanks Karl, Ralf