Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753845AbdF0WFe (ORCPT ); Tue, 27 Jun 2017 18:05:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:47978 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753016AbdF0WF1 (ORCPT ); Tue, 27 Jun 2017 18:05:27 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FCC9214D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mhiramat@kernel.org Date: Wed, 28 Jun 2017 07:05:23 +0900 From: Masami Hiramatsu To: Steven Rostedt Cc: Sabrina Dubroca , linux-kernel@vger.kernel.org, Ingo Molnar , Hannes Frederic Sowa Subject: Re: [PATCH] tracing/kprobes: allow to create probe with a module name starting with a digit Message-Id: <20170628070523.ab19eeb9b9b0ac7e21e0705f@kernel.org> In-Reply-To: <20170627100745.300bc747@gandalf.local.home> References: <20170627173830.80e06e87716742a7cc4a6257@kernel.org> <20170627100745.300bc747@gandalf.local.home> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 966 Lines: 38 On Tue, 27 Jun 2017 10:07:45 -0400 Steven Rostedt wrote: > On Tue, 27 Jun 2017 17:38:30 +0900 > Masami Hiramatsu wrote: > > > On Thu, 22 Jun 2017 11:24:42 +0200 > > Sabrina Dubroca wrote: > > > > > Always try to parse an address, since kstrtoul() will safely fail when > > > given a symbol as input. If that fails (which will be the case for a > > > symbol), try to parse a symbol instead. > > > > > > This allows creating a probe such as: > > > > > > p:probe/vlan_gro_receive 8021q:vlan_gro_receive+0 > > > > > > Which is necessary for this command to work: > > > > > > perf probe -m 8021q -a vlan_gro_receive > > > > > > > Ah, I forgot that case. > > Nice catch! > > > > Acked-by: Masami Hiramatsu > > > > Thanks Masami, > > I can take this. Should this go to stable? Yes, it should go to stable. Thank you, -- Masami Hiramatsu