Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753959AbdF0W5K (ORCPT ); Tue, 27 Jun 2017 18:57:10 -0400 Received: from mail-wr0-f179.google.com ([209.85.128.179]:34252 "EHLO mail-wr0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753461AbdF0W5C (ORCPT ); Tue, 27 Jun 2017 18:57:02 -0400 MIME-Version: 1.0 In-Reply-To: <1496900032.1929.9.camel@perches.com> References: <20170530094901.1807-1-hiroh@chromium.org> <1496139572.2618.19.camel@perches.com> <1496196991.2618.47.camel@perches.com> <1496203602.2618.54.camel@perches.com> <0eb529d9-a710-4305-f0e2-e2fcd5d5433a@xs4all.nl> <1496898982.1929.7.camel@perches.com> <1496900032.1929.9.camel@perches.com> From: Hirokazu Honda Date: Wed, 28 Jun 2017 07:57:00 +0900 Message-ID: Subject: Re: [PATCH v2] [media] vb2: core: Lower the log level of debug outputs To: Joe Perches Cc: Tomasz Figa , Hans Verkuil , Pawel Osciak , Kyungmin Park , Marek Szyprowski , Mauro Carvalho Chehab , linux-media@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1045 Lines: 29 Hi, According to patch work, this patch are not approved yet and its status are "Changes Requested." What changes are necessary actually? If there is no necessary change, can you approve this patch? Best, Hirokazu Honda On Thu, Jun 8, 2017 at 2:33 PM, Joe Perches wrote: > On Thu, 2017-06-08 at 14:24 +0900, Tomasz Figa wrote: >> On Thu, Jun 8, 2017 at 2:16 PM, Joe Perches wrote: > [] >> > If there automated systems that rely on specific levels, then >> > changing the levels of individual messages could also cause >> > those automated systems to fail. >> >> Well, that might be true for some of them indeed. I was thinking about >> our use case, which relies on particular numbers to get expected >> verbosity levels not caring about particular messages. I guess the >> break all or none rule is going to apply here, so we should do the >> bitmap conversion indeed. :) >> >> On the other hand, I think it would be still preferable to do the >> conversion in a separate patch. > > Right. No worries. >