Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754008AbdF0XVH (ORCPT ); Tue, 27 Jun 2017 19:21:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:52630 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752792AbdF0XVA (ORCPT ); Tue, 27 Jun 2017 19:21:00 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67D2A214D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org Date: Tue, 27 Jun 2017 18:20:57 -0500 From: Bjorn Helgaas To: Ryder Lee Cc: Andrew Morton , Stephen Rothwell , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: mediatek: change to use the new host bridge interface Message-ID: <20170627232057.GK17844@bhelgaas-glaptop.roam.corp.google.com> References: <1498555451-55073-1-git-send-email-ryder.lee@mediatek.com> <1498555451-55073-2-git-send-email-ryder.lee@mediatek.com> <20170627223039.GE17844@bhelgaas-glaptop.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170627223039.GE17844@bhelgaas-glaptop.roam.corp.google.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1336 Lines: 30 On Tue, Jun 27, 2017 at 05:30:40PM -0500, Bjorn Helgaas wrote: > On Tue, Jun 27, 2017 at 05:24:11PM +0800, Ryder Lee wrote: > > With the introduction of pci_scan_root_bus_bridge() there is no need to > > export pci_register_host_bridge() to other kernel subsystems other than the > > PCI compilation unit that needs it. > > > > Make pci_register_host_bridge() static to its compilation unit and convert > > the existing drivers usage over to pci_scan_root_bus_bridge(). > > > > Also, when probing the PCI host controller driver, if an error occurs, the probe > > function code does not free memory allocated for the struct pci_host_bridge > > resulting in memory leakage. > > > > This patch fixes them by using the methods that introduces by Lorenzo. > > > > Signed-off-by: Ryder Lee > > I rebased my pci/host-mediatek branch on top of pci/enumeration (which > contains the series from Lorenzo), and folded this into the initial > MediaTek driver commit. > > This branch: > > https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?h=pci/host-mediatek&id=b6ca15d18881b784dc9efc5d81989be26ecd9fc8 > > should have all the MediaTek bits I know about. Can you double-check > it, please? Sorry, that's wrong; I see your controller powerup stuff in patchwork, and that's *not* included yet.