Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753488AbdF1BVh (ORCPT ); Tue, 27 Jun 2017 21:21:37 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:4184 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752010AbdF1BVc (ORCPT ); Tue, 27 Jun 2017 21:21:32 -0400 Message-ID: <1498612886.20242.12.camel@mtkswgap22> Subject: Re: [PATCH] PCI: mediatek: change to use the new host bridge interface From: Ryder Lee To: Bjorn Helgaas CC: Andrew Morton , Stephen Rothwell , Bjorn Helgaas , , Date: Wed, 28 Jun 2017 09:21:26 +0800 In-Reply-To: <20170627232057.GK17844@bhelgaas-glaptop.roam.corp.google.com> References: <1498555451-55073-1-git-send-email-ryder.lee@mediatek.com> <1498555451-55073-2-git-send-email-ryder.lee@mediatek.com> <20170627223039.GE17844@bhelgaas-glaptop.roam.corp.google.com> <20170627232057.GK17844@bhelgaas-glaptop.roam.corp.google.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1547 Lines: 37 On Tue, 2017-06-27 at 18:20 -0500, Bjorn Helgaas wrote: > On Tue, Jun 27, 2017 at 05:30:40PM -0500, Bjorn Helgaas wrote: > > On Tue, Jun 27, 2017 at 05:24:11PM +0800, Ryder Lee wrote: > > > With the introduction of pci_scan_root_bus_bridge() there is no need to > > > export pci_register_host_bridge() to other kernel subsystems other than the > > > PCI compilation unit that needs it. > > > > > > Make pci_register_host_bridge() static to its compilation unit and convert > > > the existing drivers usage over to pci_scan_root_bus_bridge(). > > > > > > Also, when probing the PCI host controller driver, if an error occurs, the probe > > > function code does not free memory allocated for the struct pci_host_bridge > > > resulting in memory leakage. > > > > > > This patch fixes them by using the methods that introduces by Lorenzo. > > > > > > Signed-off-by: Ryder Lee > > > > I rebased my pci/host-mediatek branch on top of pci/enumeration (which > > contains the series from Lorenzo), and folded this into the initial > > MediaTek driver commit. > > > > This branch: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?h=pci/host-mediatek&id=b6ca15d18881b784dc9efc5d81989be26ecd9fc8 > > > > should have all the MediaTek bits I know about. Can you double-check > > it, please? > > Sorry, that's wrong; I see your controller powerup stuff in patchwork, and > that's *not* included yet. Yes, that should be folded into the initial commit if possible. Thanks for your help! Ryder