Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751536AbdF1I3z (ORCPT ); Wed, 28 Jun 2017 04:29:55 -0400 Received: from mail-vk0-f65.google.com ([209.85.213.65]:33346 "EHLO mail-vk0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751493AbdF1I3u (ORCPT ); Wed, 28 Jun 2017 04:29:50 -0400 MIME-Version: 1.0 In-Reply-To: <20170628024905.3000-1-quytelda@tamalin.org> References: <20170628024905.3000-1-quytelda@tamalin.org> From: Frans Klaver Date: Wed, 28 Jun 2017 10:29:48 +0200 Message-ID: Subject: Re: [PATCH] Staging: unisys: visorbus: Fix coding style warning from checkpatch.pl. To: Quytelda Kahja Cc: david.kershner@unisys.com, Greg KH , driverdevel , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1416 Lines: 40 Hi, On Wed, Jun 28, 2017 at 4:49 AM, Quytelda Kahja wrote: > Replace the literal function name "visorbus_create_instance" with the format > specifier "%s" so it can be dynamically filled by the __func__ macro. On a general note, I think the actual change or effect is more import to mention in the subject than the fact that you "fix some issue highlighted by checkpatch". Something like Subject: [PATCH] staging: unisys: visorbus: use __func__ instead of function name Of course you can still mention that checkpatch highlighted the issue for you in the description. > > Signed-off-by: Quytelda Kahja > --- > drivers/staging/unisys/visorbus/visorbus_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c > index 1c785dd19ddd..1c6dc3a3e64a 100644 > --- a/drivers/staging/unisys/visorbus/visorbus_main.c > +++ b/drivers/staging/unisys/visorbus/visorbus_main.c > @@ -1030,7 +1030,7 @@ visorbus_create_instance(struct visor_device *dev) > err_debugfs_dir: > debugfs_remove_recursive(dev->debugfs_dir); > kfree(hdr_info); > - dev_err(&dev->device, "visorbus_create_instance failed: %d\n", err); > + dev_err(&dev->device, "%s failed: %d\n", __func__, err); > return err; > } It looks sane, anyway. Frans