Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751552AbdF1JHY (ORCPT ); Wed, 28 Jun 2017 05:07:24 -0400 Received: from 8bytes.org ([81.169.241.247]:46718 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751453AbdF1JHQ (ORCPT ); Wed, 28 Jun 2017 05:07:16 -0400 Date: Wed, 28 Jun 2017 11:07:13 +0200 From: Joerg Roedel To: Suravee Suthikulpanit Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Joerg Roedel Subject: Re: [PATCH v2] iommu/amd: Fix interrupt remapping when disable guest_mode Message-ID: <20170628090713.GC14532@8bytes.org> References: <1498469284-85652-1-git-send-email-suravee.suthikulpanit@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1498469284-85652-1-git-send-email-suravee.suthikulpanit@amd.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 819 Lines: 22 Hi Suravee, On Mon, Jun 26, 2017 at 04:28:04AM -0500, Suravee Suthikulpanit wrote: > Pass-through devices to VM guest can get updated IRQ affinity > information via irq_set_affinity() when not running in guest mode. > Currently, AMD IOMMU driver in GA mode ignores the updated information > if the pass-through device is setup to use vAPIC regardless of guest_mode. > This could cause invalid interrupt remapping. > > Also, the guest_mode bit should be set and cleared only when > SVM updates posted-interrupt interrupt remapping information. > > Signed-off-by: Suravee Suthikulpanit > Cc: Joerg Roedel Can you please provide a 'Fixes:' tag too? No need to resend the whole patch, just reply with the tag and I'll add it when applying this patch. Thanks, Joerg