Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751520AbdF1JfJ (ORCPT <rfc822;w@1wt.eu>);
        Wed, 28 Jun 2017 05:35:09 -0400
Received: from mx2.suse.de ([195.135.220.15]:35772 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1750829AbdF1JfE (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 28 Jun 2017 05:35:04 -0400
Subject: Re: [PATCH] mm/memory_hotplug: just build zonelist for new added node
To: Michal Hocko <mhocko@kernel.org>, Wei Yang <richard.weiyang@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20170626035822.50155-1-richard.weiyang@gmail.com>
 <20170628092329.GC5225@dhcp22.suse.cz>
From: Vlastimil Babka <vbabka@suse.cz>
Message-ID: <f92958f9-e831-8dc7-f8e6-2f4a46171e71@suse.cz>
Date: Wed, 28 Jun 2017 11:35:00 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.0
MIME-Version: 1.0
In-Reply-To: <20170628092329.GC5225@dhcp22.suse.cz>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2712
Lines: 76

On 06/28/2017 11:23 AM, Michal Hocko wrote:
> On Mon 26-06-17 11:58:22, Wei Yang wrote:
>> In commit (9adb62a5df9c0fbef7) "mm/hotplug: correctly setup fallback
>> zonelists when creating new pgdat" tries to build the correct zonelist for
>> a new added node, while it is not necessary to rebuild it for already exist
>> nodes.
>>
>> In build_zonelists(), it will iterate on nodes with memory. For a new added
>> node, it will have memory until node_states_set_node() is called in
>> online_pages().
>>
>> This patch will avoid to rebuild the zonelists for already exist nodes.
> 
> It is not very clear from the changelog why that actually matters. The
> only effect I can see is that other zonelists on other online nodes will
> not learn about the currently memory less node. This is a good think
> because we do not pointlessly try to allocate from that node.

build_zonelists_node() seems to use managed_zone(zone) checks, so it
should not include empty zones anyway. So effectively seems to me we
just avoid some pointless work under stop_machine().

>> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> 
> Acked-by: Michal Hocko <mhocko@suse.com>
> 
>> ---
>>  mm/page_alloc.c | 16 +++++++++-------
>>  1 file changed, 9 insertions(+), 7 deletions(-)
>>
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index 560eafe8234d..fc8181b44fd8 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -5200,15 +5200,17 @@ static int __build_all_zonelists(void *data)
>>  	memset(node_load, 0, sizeof(node_load));
>>  #endif
>>  
>> -	if (self && !node_online(self->node_id)) {
>> +	/* This node is hotadded and no memory preset yet.
>> +	 * So just build zonelists is fine, no need to touch other nodes.
>> +	 */
> 
> This comment doesn't make much sense to me. What about
> 	/*
> 	 * Do not rebuild zonelists on all online nodes if the current
> 	 * node is not online yet (it doesn't have any memory) and
> 	 * allocating from it is pointless. Still build zonelist for
> 	 * self because we need to handle memoryless nodes.
> 	 */
>> +	if (self && !node_online(self->node_id))
>>  		build_zonelists(self);
>> -	}
>> -
>> -	for_each_online_node(nid) {
>> -		pg_data_t *pgdat = NODE_DATA(nid);
>> +	else
>> +		for_each_online_node(nid) {
>> +			pg_data_t *pgdat = NODE_DATA(nid);
>>  
>> -		build_zonelists(pgdat);
>> -	}
>> +			build_zonelists(pgdat);
>> +		}
>>  
>>  	/*
>>  	 * Initialize the boot_pagesets that are going to be used
>> -- 
>> 2.11.0
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@kvack.org.  For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>