Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751656AbdF1Jp2 (ORCPT ); Wed, 28 Jun 2017 05:45:28 -0400 Received: from mail-yw0-f196.google.com ([209.85.161.196]:34055 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751540AbdF1JpT (ORCPT ); Wed, 28 Jun 2017 05:45:19 -0400 MIME-Version: 1.0 X-Originating-IP: [82.81.71.2] In-Reply-To: <1498642633-3260-1-git-send-email-karthik@techveda.org> References: <1498642633-3260-1-git-send-email-karthik@techveda.org> From: Gilad Ben-Yossef Date: Wed, 28 Jun 2017 12:45:18 +0300 Message-ID: Subject: Re: [PATCH 0/2] staging: ccree: Fix coding style and remove warnings To: karthik@techveda.org Cc: Greg Kroah-Hartman , linux-crypto@vger.kernel.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, Linux kernel mailing list , sunil.m@techveda.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1124 Lines: 46 Thank you Karthik, On Wed, Jun 28, 2017 at 12:37 PM, wrote: > From: Karthik Tummala > > This patch series fixes coding style and removes the following > checkpatch.pl warnings: > > Prefer using '"%s...", __func__' to using the function's name, > in a string. This one is good. > > Braces {} are not necessary for single statement blocks. I have already sent a patch addressing this and some other things yesterday/ > > Rebased on top of next-20170627. > Patches were tested and built on next-20170627 Can you please check patch 1 still applies after yesterdays patch series? > > Karthik Tummala (2): > staging: ccree: Use __func__ instead of function name > staging: ccree: Remove braces {} for single statement blocks > > drivers/staging/ccree/ssi_aead.c | 48 ++++++++++++++++------------------------ > 1 file changed, 19 insertions(+), 29 deletions(-) > > -- > 1.9.1 > Thanks, Gilad -- Gilad Ben-Yossef Chief Coffee Drinker "If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" -- Jean-Baptiste Queru