Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751557AbdF1LAf (ORCPT ); Wed, 28 Jun 2017 07:00:35 -0400 Received: from www.llwyncelyn.cymru ([82.70.14.225]:45600 "EHLO fuzix.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751503AbdF1LA1 (ORCPT ); Wed, 28 Jun 2017 07:00:27 -0400 Date: Wed, 28 Jun 2017 12:00:03 +0100 From: Alan Cox To: Daniel Vetter Cc: Intel Graphics Development , LKML , Alan Cox , Sergey Senozhatsky , Linux Fbdev development list , Steven Rostedt , Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, Daniel Vetter Subject: Re: [PATCH] fbcon: Make fbcon a built-time depency for fbdev Message-ID: <20170628120003.6e2f1ef6@alans-desktop> In-Reply-To: <20170628103635.24651-1-daniel.vetter@ffwll.ch> References: <20170628103635.24651-1-daniel.vetter@ffwll.ch> Organization: Intel Corporation X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1147 Lines: 30 On Wed, 28 Jun 2017 12:36:35 +0200 Daniel Vetter wrote: > There's a bunch of folks who're trying to make printk less > contended and faster, but there's a problem: printk uses the > console_lock, and the console lock has become the BKL for all things > fbdev/fbcon, which in turn pulled in half the drm subsystem under that > lock. That's awkward. Yes - very. Although if you implement your console printing method with sufficient cunning it shouldn't cause much latency in most cases but for unaccelerated fb it's really bad. It also makes it unnecessarily hard for a drm driver to accelerate console output. > 4. Push console_lock down the call-chain, until it is down in > console_register again. I don't think that's actually going to work out. To fix it is going to need more invasive changes so that you can 'create' a console and set it up separately to actually 'enabling' it when you make it visible and start scribbling. I don't see any other way to make the changeover locking saner at this point without still having huge potential stalls in printk(). Reviewed-by: Alan Cox Alan