Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751614AbdF1LVT (ORCPT ); Wed, 28 Jun 2017 07:21:19 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:47560 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751498AbdF1LVO (ORCPT ); Wed, 28 Jun 2017 07:21:14 -0400 Date: Wed, 28 Jun 2017 13:21:12 +0200 From: Greg Kroah-Hartman To: Arnd Bergmann Cc: Zhongping Tan =?utf-8?B?KOiwreS4reW5syk=?= , Linux Kernel Mailing List Subject: Re: [RFC PATCH] char: misc: Init misc->list in a safe way Message-ID: <20170628112112.GE7389@kroah.com> References: <8f919e212d5149e286422d58a5732356@SHMBX02.spreadtrum.com> <20170627062917.GA10376@kroah.com> <20170628015431.GA32195@spreadtrum.com> <20170628051815.GA4748@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 902 Lines: 25 On Wed, Jun 28, 2017 at 12:34:28PM +0200, Arnd Bergmann wrote: > On Wed, Jun 28, 2017 at 7:18 AM, Greg Kroah-Hartman > wrote: > > On Wed, Jun 28, 2017 at 09:54:32AM +0800, Orson Zhai wrote: > >> We found the device is "fm". We highly suspect that fm driver call > >> misc_register twice and reinitialize list to make ->pre & ->next > >> pointing to himself. > >> > >> Meanwhile, we checked fm driver and found nothing obviously wrong in the code. > > > > Do you have a pointer to this driver? Is it in the kernel tree? > > I found a version of some spreadtrum FM driver in the sources for the > Samsung Galaxy > J3, this is the driver https://pastebin.com/p7Y7xQNE Ah nice, Orson, is that the driver? Any objection for me adding it to the kernel tree so we can fix up the issues that Arnd points out in it (not to mention the coding style issues...) thanks, greg k-h