Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752289AbdF1MCa (ORCPT ); Wed, 28 Jun 2017 08:02:30 -0400 Received: from 8bytes.org ([81.169.241.247]:48394 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751642AbdF1MCG (ORCPT ); Wed, 28 Jun 2017 08:02:06 -0400 From: Joerg Roedel To: iommu@lists.linux-foundation.org Cc: linux-kernel@vger.kernel.org, Gerald Schaefer , Suman Anna , Joerg Roedel Subject: [PATCH 3/3] iommu: Warn once when device_group callback returns NULL Date: Wed, 28 Jun 2017 14:00:58 +0200 Message-Id: <1498651258-23700-3-git-send-email-joro@8bytes.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1498651258-23700-1-git-send-email-joro@8bytes.org> References: <1498651258-23700-1-git-send-email-joro@8bytes.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 675 Lines: 26 From: Joerg Roedel This callback should never return NULL. Print a warning if that happens so that we notice and can fix it. Signed-off-by: Joerg Roedel --- drivers/iommu/iommu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index de09e1e..3f6ea16 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -1010,6 +1010,9 @@ struct iommu_group *iommu_group_get_for_dev(struct device *dev) if (ops && ops->device_group) group = ops->device_group(dev); + if (WARN_ON_ONCE(group == NULL)) + return ERR_PTR(-EINVAL); + if (IS_ERR(group)) return group; -- 2.7.4