Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751982AbdF1MqQ (ORCPT ); Wed, 28 Jun 2017 08:46:16 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:48473 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751556AbdF1MqJ (ORCPT ); Wed, 28 Jun 2017 08:46:09 -0400 Date: Wed, 28 Jun 2017 15:45:22 +0300 From: Dan Carpenter To: Jaya Durga Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, florian.c.schilhabel@googlemail.com, Jaya Durga , driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net Subject: Re: [PATCH 4/4] Staging: rtl8712 : ieee80211.c: fixed camelcase coding Message-ID: <20170628124522.v4p2ksnexzad2krh@mwanda> References: <1498563819-31358-1-git-send-email-rjdurga@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1498563819-31358-1-git-send-email-rjdurga@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 598 Lines: 21 On Tue, Jun 27, 2017 at 05:13:39PM +0530, Jaya Durga wrote: > diff --git a/drivers/staging/rtl8712/osdep_intf.h b/drivers/staging/rtl8712/osdep_intf.h > index 1985423..dac6aed 100644 > --- a/drivers/staging/rtl8712/osdep_intf.h > +++ b/drivers/staging/rtl8712/osdep_intf.h > @@ -29,7 +29,10 @@ > #include "osdep_service.h" > #include "drv_types.h" > > -#define RND4(x) ((((x) >> 2) + ((((x) & 3) == 0) ? 0 : 1)) << 2) > +static inline unsigned int RND4(unsigned int x) > +{ > + return (((x >> 2) + (((x & 3) == 0) ? 0 : 1)) << 2); > +} > Don't mix unrelated stuff. regards, dan carpenter